mirror of
https://github.com/roc-lang/roc.git
synced 2025-11-02 05:48:17 +00:00
dd55be6142
Suppose we have a when expression
```
15 if foo -> <b1>
b if bar -> <b2>
_ -> <b3>
```
that may have a decision tree like
```
15?
\true => foo?
\true => <b1>
\false => bar?
\true => <b2>
\false => <b3>
\false => bar?
\true => <b2>
\false => <b3>
```
In this case, the guard "bar?" appears twice in the compiled decision
tree. We need to materialize the guard expression in both locations in
the compiled tree, which means we cannot as-is stamp a compiled `bar?`
twice in each location. The reason is that
- the compiled joinpoint for each `bar?` guard needs to have a unique ID
- the guard expression might have call which needs unique call spec IDs,
or other joins that need unique joinpoint IDs.
So, save the expression as we build up the decision tree and materialize
the guard each time we need it. In practice the guards should be quite
small, so duplicating should be fine. We could avoid duplication, but
it's not clear to me how to do that exactly since the branches after the
guard might end up being different.
|
||
|---|---|---|
| .. | ||
| alias_variable.txt | ||
| alias_variable_and_return_it.txt | ||
| anonymous_closure_in_polymorphic_expression_issue_4717.txt | ||
| anonymous_closure_lifted_to_named_issue_2403.txt | ||
| branch_store_variable.txt | ||
| call_function_in_empty_list.txt | ||
| call_function_in_empty_list_unbound.txt | ||
| choose_correct_recursion_var_under_record.txt | ||
| choose_i128_layout.txt | ||
| choose_u64_layout.txt | ||
| choose_u128_layout.txt | ||
| closure_in_list.txt | ||
| crash.txt | ||
| dict.txt | ||
| empty_list_of_function_type.txt | ||
| encode.txt | ||
| encode_derived_nested_record_string.txt | ||
| encode_derived_record_one_field_string.txt | ||
| encode_derived_record_two_field_strings.txt | ||
| encode_derived_string.txt | ||
| encode_derived_tag_one_field_string.txt | ||
| encode_derived_tag_two_payloads_string.txt | ||
| factorial.txt | ||
| fst.txt | ||
| function_pointer_lambda_set.txt | ||
| function_specialization_information_in_lambda_set_thunk.txt | ||
| function_specialization_information_in_lambda_set_thunk_independent_defs.txt | ||
| guard_pattern_true.txt | ||
| if_guard_bind_variable_false.txt | ||
| if_multi_branch.txt | ||
| inline_return_joinpoints_in_bool_lambda_set.txt | ||
| inline_return_joinpoints_in_enum_lambda_set.txt | ||
| inline_return_joinpoints_in_union_lambda_set.txt | ||
| instantiate_annotated_as_recursive_alias_multiple_polymorphic_expr.txt | ||
| instantiate_annotated_as_recursive_alias_polymorphic_expr.txt | ||
| instantiate_annotated_as_recursive_alias_toplevel.txt | ||
| ir_assignment.txt | ||
| ir_int_add.txt | ||
| ir_int_literal.txt | ||
| ir_plus.txt | ||
| ir_round.txt | ||
| ir_two_defs.txt | ||
| ir_when_idiv.txt | ||
| ir_when_just.txt | ||
| ir_when_maybe.txt | ||
| ir_when_record.txt | ||
| ir_when_these.txt | ||
| is_nil.txt | ||
| issue_2535_let_weakened_fields_referenced_in_list.txt | ||
| issue_2583_specialize_errors_behind_unified_branches.txt | ||
| issue_2725_alias_polymorphic_lambda.txt | ||
| issue_2810.txt | ||
| issue_2811.txt | ||
| issue_3560_nested_tag_constructor_is_newtype.txt | ||
| issue_3669.txt | ||
| issue_4557.txt | ||
| issue_4705.txt | ||
| issue_4749.txt | ||
| issue_4772_weakened_monomorphic_destructure.txt | ||
| lambda_capture_niche_u8_vs_u64.txt | ||
| lambda_capture_niches_have_captured_function_in_closure.txt | ||
| lambda_capture_niches_with_non_capturing_function.txt | ||
| lambda_capture_niches_with_other_lambda_capture.txt | ||
| lambda_set_niche_same_layout_different_constructor.txt | ||
| lambda_set_with_imported_toplevels_issue_4733.txt | ||
| let_with_record_pattern.txt | ||
| let_with_record_pattern_list.txt | ||
| let_x_in_x.txt | ||
| let_x_in_x_indirect.txt | ||
| list_append.txt | ||
| list_append_closure.txt | ||
| list_cannot_update_inplace.txt | ||
| list_get.txt | ||
| list_len.txt | ||
| list_map_closure_borrows.txt | ||
| list_map_closure_owns.txt | ||
| list_map_take_capturing_or_noncapturing.txt | ||
| list_one_vs_one_spread_issue_4685.txt | ||
| list_pass_to_function.txt | ||
| list_sort_asc.txt | ||
| match_list.txt | ||
| match_on_result_with_uninhabited_error_branch.txt | ||
| mk_pair_of.txt | ||
| monomorphized_applied_tag.txt | ||
| monomorphized_floats.txt | ||
| monomorphized_ints.txt | ||
| monomorphized_list.txt | ||
| monomorphized_tag.txt | ||
| monomorphized_tag_with_aliased_args.txt | ||
| nested_closure.txt | ||
| nested_pattern_match.txt | ||
| nullable_wrapped_with_non_nullable_singleton_tags.txt | ||
| nullable_wrapped_with_nullable_not_last_index.txt | ||
| num_width_gt_u8_layout_as_float.txt | ||
| one_element_tag.txt | ||
| opaque_assign_to_symbol.txt | ||
| optional_when.txt | ||
| order_list_size_tests_issue_4732.txt | ||
| pattern_as_nested.txt | ||
| pattern_as_of_symbol.txt | ||
| pattern_as_toplevel.txt | ||
| peano.txt | ||
| peano1.txt | ||
| peano2.txt | ||
| polymorphic_expression_unification.txt | ||
| quicksort_help.txt | ||
| quicksort_swap.txt | ||
| record_optional_field_function_no_use_default.txt | ||
| record_optional_field_function_use_default.txt | ||
| record_optional_field_let_no_use_default.txt | ||
| record_optional_field_let_use_default.txt | ||
| recursive_call_capturing_function.txt | ||
| recursive_closure_with_transiently_used_capture.txt | ||
| recursive_lambda_set_has_nested_non_recursive_lambda_sets_issue_5026.txt | ||
| recursively_build_effect.txt | ||
| rigids.txt | ||
| simple_if.txt | ||
| specialize_ability_call.txt | ||
| specialize_closures.txt | ||
| specialize_lowlevel.txt | ||
| tail_call_elimination.txt | ||
| tail_call_with_different_layout.txt | ||
| tail_call_with_same_layout_different_lambda_sets.txt | ||
| toplevel_accessor_fn_thunk.txt | ||
| tuple_pattern_match.txt | ||
| unreachable_branch_is_eliminated_but_produces_lambda_specializations.txt | ||
| unreachable_void_constructor.txt | ||
| unspecialized_lambda_set_unification_does_not_duplicate_identical_concrete_types.txt | ||
| unspecialized_lambda_set_unification_keeps_all_concrete_types_without_unification.txt | ||
| unspecialized_lambda_set_unification_keeps_all_concrete_types_without_unification_of_unifiable.txt | ||
| weakening_avoids_overspecialization.txt | ||
| when_guard_appears_multiple_times_in_compiled_decision_tree_issue_5176.txt | ||
| when_joinpoint.txt | ||
| when_nested_maybe.txt | ||
| when_on_record.txt | ||
| when_on_result.txt | ||
| when_on_two_values.txt | ||