language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-09 21:28:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Use SmallVec#extend_from_slice in lieu of SmallVec#extend (#5793)

Browse source 
## Summary

There's a note in the docs that suggests this can be faster, and in the
benchmarks it... seems like it is? Might just be noise but held up over
a few runs.

Before:

<img width="1792" alt="Screen Shot 2023-07-15 at 9 10 06 PM"
src="973cd955-d4e6-4ae3-898e-90b7eb52ecf2">

After:

<img width="1792" alt="Screen Shot 2023-07-15 at 9 10 09 PM"
src="1491b391-d219-48e9-aa47-110bc7dc7f90">
This commit is contained in:
Charlie Marsh 2023-07-15 21:25:12 -04:00 • committed by GitHub
parent 4782675bf9
commit 06b5c6c06f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
crates/ruff_python_semantic/src/model.rs
View file

@ -5,7 +5,7 @@ use bitflags::bitflags;
use nohash_hasher::{BuildNoHashHasher, IntMap};
use ruff_text_size::TextRange;
use rustpython_parser::ast::{Expr, Ranged, Stmt};
use smallvec::smallvec;
use smallvec::SmallVec;
use ruff_python_ast::call_path::{collect_call_path, from_unqualified_name, CallPath};
use ruff_python_ast::helpers::from_relative_import;
@ -526,7 +526,7 @@ impl<'a> SemanticModel<'a> {
/// ...then `resolve_call_path(${python_version})` will resolve to `sys.version_info`.
pub fn resolve_call_path(&'a self, value: &'a Expr) -> Option<CallPath<'a>> {
let call_path = collect_call_path(value)?;
let head = call_path.first()?;
let (head, tail) = call_path.split_first()?;
let binding = self.find_binding(head)?;
match &binding.kind {
BindingKind::Import(Import {
@ -537,12 +537,12 @@ impl<'a> SemanticModel<'a> {
if source_path.is_empty() {
None
} else {
source_path.extend(call_path.into_iter().skip(1));
source_path.extend_from_slice(tail);
Some(source_path)
}
} else {
let mut source_path: CallPath = from_unqualified_name(name);
source_path.extend(call_path.into_iter().skip(1));
source_path.extend_from_slice(tail);
Some(source_path)
}
}
@ -551,7 +551,7 @@ impl<'a> SemanticModel<'a> {
}) => {
let name = name.split('.').next().unwrap_or(name);
let mut source_path: CallPath = from_unqualified_name(name);
source_path.extend(call_path.into_iter().skip(1));
source_path.extend_from_slice(tail);
Some(source_path)
}
BindingKind::FromImport(FromImport {
@ -562,19 +562,19 @@ impl<'a> SemanticModel<'a> {
if source_path.is_empty() {
None
} else {
source_path.extend(call_path.into_iter().skip(1));
source_path.extend_from_slice(tail);
Some(source_path)
}
} else {
let mut source_path: CallPath = from_unqualified_name(name);
source_path.extend(call_path.into_iter().skip(1));
source_path.extend_from_slice(tail);
Some(source_path)
}
}
BindingKind::Builtin => {
let mut source_path: CallPath = smallvec![];
let mut source_path: CallPath = SmallVec::with_capacity(1 + call_path.len());
source_path.push("");
source_path.extend(call_path);
source_path.extend_from_slice(call_path.as_slice());
Some(source_path)
}
_ => None,