language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-11-01 12:25:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[syntax-errors] Detect single starred expression assignment x = *y (#17624)

Browse source 
## Summary

Part of #17412

Starred expressions cannot be used as values in assignment expressions.
Add a new semantic syntax error to catch such instances.
Note that we already have
`ParseErrorType::InvalidStarredExpressionUsage` to catch some starred
expression errors during parsing, but that does not cover top level
assignment expressions.

## Test Plan

- Added new inline tests for the new rule
- Found some examples marked as "valid" in existing tests (`_ = *data`),
which are not really valid (per this new rule) and updated them
- There was an existing inline test - `assign_stmt_invalid_value_expr`
which had instances of `*` expression which would be deemed invalid by
this new rule. Converted these to tuples, so that they do not trigger
this new rule.
This commit is contained in:
Abhijeet Prasad Bodas 2025-05-01 00:34:00 +05:30 • committed by GitHub
parent f31b1c695c
commit 0eeb02c0c1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 661 additions and 217 deletions
Download patch file Download diff file Expand all files Collapse all files

84
crates/ruff_python_parser/tests/snapshots/valid_syntax@statement__assignment.py.snap
View file

@ -7,7 +7,7 @@ input_file: crates/ruff_python_parser/resources/valid/statement/assignment.py
```
Module(
ModModule {
range: 0..723,
range: 0..729,
body: [
Assign(
StmtAssign {
@ -802,7 +802,7 @@ Module(
),
Assign(
StmtAssign {
range: 682..692,
range: 682..695,
targets: [
List(
ExprList {
@ -812,67 +812,85 @@ Module(
},
),
],
value: Starred(
ExprStarred {
range: 687..692,
value: Name(
ExprName {
range: 688..692,
id: Name("data"),
ctx: Load,
},
),
value: Tuple(
ExprTuple {
range: 687..695,
elts: [
Starred(
ExprStarred {
range: 688..693,
value: Name(
ExprName {
range: 689..693,
id: Name("data"),
ctx: Load,
},
),
ctx: Load,
},
),
],
ctx: Load,
parenthesized: true,
},
),
},
),
Assign(
StmtAssign {
range: 693..703,
range: 696..709,
targets: [
Tuple(
ExprTuple {
range: 693..695,
range: 696..698,
elts: [],
ctx: Store,
parenthesized: true,
},
),
],
value: Starred(
ExprStarred {
range: 698..703,
value: Name(
ExprName {
range: 699..703,
id: Name("data"),
ctx: Load,
},
),
value: Tuple(
ExprTuple {
range: 701..709,
elts: [
Starred(
ExprStarred {
range: 702..707,
value: Name(
ExprName {
range: 703..707,
id: Name("data"),
ctx: Load,
},
),
ctx: Load,
},
),
],
ctx: Load,
parenthesized: true,
},
),
},
),
Assign(
StmtAssign {
range: 704..713,
range: 710..719,
targets: [
Tuple(
ExprTuple {
range: 704..708,
range: 710..714,
elts: [
Name(
ExprName {
range: 704..705,
range: 710..711,
id: Name("a"),
ctx: Store,
},
),
Name(
ExprName {
range: 707..708,
range: 713..714,
id: Name("b"),
ctx: Store,
},
@ -885,7 +903,7 @@ Module(
],
value: Name(
ExprName {
range: 711..713,
range: 717..719,
id: Name("ab"),
ctx: Load,
},
@ -894,18 +912,18 @@ Module(
),
Assign(
StmtAssign {
range: 714..723,
range: 720..729,
targets: [
Name(
ExprName {
range: 714..715,
range: 720..721,
id: Name("a"),
ctx: Store,
},
),
Name(
ExprName {
range: 718..719,
range: 724..725,
id: Name("b"),
ctx: Store,
},
@ -913,7 +931,7 @@ Module(
],
value: Name(
ExprName {
range: 722..723,
range: 728..729,
id: Name("c"),
ctx: Load,
},