mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-29 21:35:58 +00:00
Rename applicability levels to Safe
, Unsafe
, and Display
(#7843)
After working with the previous change in https://github.com/astral-sh/ruff/pull/7821 I found the names a bit unclear and their relationship with the user-facing API muddied. Since the applicability is exposed to the user directly in our JSON output, I think it's important that these names align with our configuration options. I've replaced `Manual` or `Never` with `Display` which captures our intent for these fixes (only for display). Here, we create room for future levels, such as `HasPlaceholders`, which wouldn't fit into the `Always`/`Sometimes`/`Never` levels. Unlike https://github.com/astral-sh/ruff/pull/7819, this retains the flat enum structure which is easier to work with.
This commit is contained in:
parent
4b537d1297
commit
0fc76ba276
188 changed files with 343 additions and 371 deletions
|
@ -53,9 +53,9 @@ impl Display for Diff<'_> {
|
|||
|
||||
let message = match self.fix.applicability() {
|
||||
// TODO(zanieb): Adjust this messaging once it's user-facing
|
||||
Applicability::Always => "Fix",
|
||||
Applicability::Sometimes => "Suggested fix",
|
||||
Applicability::Never => "Possible fix",
|
||||
Applicability::Safe => "Fix",
|
||||
Applicability::Unsafe => "Suggested fix",
|
||||
Applicability::Display => "Possible fix",
|
||||
};
|
||||
writeln!(f, "ℹ {}", message.blue())?;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue