mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-29 21:35:58 +00:00
[red-knot] Precise inference for identity checks (#14109)
## Summary Adds more precise type inference for `… is …` and `… is not …` identity checks in some limited cases where we statically know the answer to be either `Literal[True]` or `Literal[False]`. I found this helpful while working on type inference for comparisons involving intersection types, but I'm not sure if this is at all useful for real world code (where the answer is most probably *not* statically known). Note that we already have *type narrowing* for identity tests. So while we are already able to generate constraints for things like `if x is None`, we can now — in some limited cases — make an even stronger conclusion and infer that the test expression itself is `Literal[False]` (branch never taken) or `Literal[True]` (branch always taken). ## Test Plan New Markdown tests
This commit is contained in:
parent
05687285fe
commit
2296627528
2 changed files with 62 additions and 2 deletions
|
@ -0,0 +1,40 @@
|
|||
# Identity tests
|
||||
|
||||
```py
|
||||
class A: ...
|
||||
|
||||
def get_a() -> A: ...
|
||||
def get_object() -> object: ...
|
||||
|
||||
a1 = get_a()
|
||||
a2 = get_a()
|
||||
|
||||
n1 = None
|
||||
n2 = None
|
||||
|
||||
o = get_object()
|
||||
|
||||
reveal_type(a1 is a1) # revealed: bool
|
||||
reveal_type(a1 is a2) # revealed: bool
|
||||
|
||||
reveal_type(n1 is n1) # revealed: Literal[True]
|
||||
reveal_type(n1 is n2) # revealed: Literal[True]
|
||||
|
||||
reveal_type(a1 is n1) # revealed: Literal[False]
|
||||
reveal_type(n1 is a1) # revealed: Literal[False]
|
||||
|
||||
reveal_type(a1 is o) # revealed: bool
|
||||
reveal_type(n1 is o) # revealed: bool
|
||||
|
||||
reveal_type(a1 is not a1) # revealed: bool
|
||||
reveal_type(a1 is not a2) # revealed: bool
|
||||
|
||||
reveal_type(n1 is not n1) # revealed: Literal[False]
|
||||
reveal_type(n1 is not n2) # revealed: Literal[False]
|
||||
|
||||
reveal_type(a1 is not n1) # revealed: Literal[True]
|
||||
reveal_type(n1 is not a1) # revealed: Literal[True]
|
||||
|
||||
reveal_type(a1 is not o) # revealed: bool
|
||||
reveal_type(n1 is not o) # revealed: bool
|
||||
```
|
|
@ -3388,8 +3388,28 @@ impl<'db> TypeInferenceBuilder<'db> {
|
|||
ast::CmpOp::NotIn => {
|
||||
membership_test_comparison(MembershipTestCompareOperator::NotIn)
|
||||
}
|
||||
ast::CmpOp::Is => Ok(KnownClass::Bool.to_instance(self.db)),
|
||||
ast::CmpOp::IsNot => Ok(KnownClass::Bool.to_instance(self.db)),
|
||||
ast::CmpOp::Is => {
|
||||
if left.is_disjoint_from(self.db, right) {
|
||||
Ok(Type::BooleanLiteral(false))
|
||||
} else if left.is_singleton(self.db)
|
||||
&& left.is_equivalent_to(self.db, right)
|
||||
{
|
||||
Ok(Type::BooleanLiteral(true))
|
||||
} else {
|
||||
Ok(KnownClass::Bool.to_instance(self.db))
|
||||
}
|
||||
}
|
||||
ast::CmpOp::IsNot => {
|
||||
if left.is_disjoint_from(self.db, right) {
|
||||
Ok(Type::BooleanLiteral(true))
|
||||
} else if left.is_singleton(self.db)
|
||||
&& left.is_equivalent_to(self.db, right)
|
||||
{
|
||||
Ok(Type::BooleanLiteral(false))
|
||||
} else {
|
||||
Ok(KnownClass::Bool.to_instance(self.db))
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
// TODO: handle more types
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue