language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-01 06:11:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[red-knot] visit with-item vars even if not a Name (#13409)

Browse source 
This fixes the last panic on checking pandas.

(Match statement became an `if let` because clippy decided it wanted
that once I added the additional line in the else case?)

---------

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This commit is contained in:
Carl Meyer 2024-09-19 10:37:49 -07:00 • committed by GitHub
parent f110d80279
commit 260c2ecd15
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/red_knot_python_semantic/src/types/infer.rs
View file

@ -926,14 +926,13 @@ impl<'db> TypeInferenceBuilder<'db> {
} = with_statement; } = with_statement;
for item in items { for item in items {
match item.optional_vars.as_deref() { let target = item.optional_vars.as_deref();
Some(ast::Expr::Name(name)) => { if let Some(ast::Expr::Name(name)) = target {
self.infer_definition(name); self.infer_definition(name);
} } else {
_ => { // TODO infer definitions in unpacking assignment
// TODO infer definitions in unpacking assignment self.infer_expression(&item.context_expr);
self.infer_expression(&item.context_expr); self.infer_optional_expression(target);
}
} }
} }

2
crates/red_knot_workspace/resources/test/corpus/67_with_non_name_target.py Normal file
View file

@ -0,0 +1,2 @@
with foo() as self.bar:
pass