language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-26 20:09:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[syntax-errors] Fix false positive for parenthesized tuple index (#16948)

Browse source 
Summary
--

Fixes #16943 by checking if the tuple is not parenthesized before
emitting an error.

Test Plan
--

New inline test based on the initial report
This commit is contained in:
Brent Westbrook 2025-03-24 10:34:38 -04:00 • committed by GitHub
parent f5cdf23545
commit 2711e08eb8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 153 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff_python_parser/resources/inline/ok/parenthesized_star_index_py310.py Normal file
View file

@ -0,0 +1,2 @@
# parse_options: {"target-version": "3.10"}
out[(*(slice(None) for _ in range(2)), *ind)] = 1

11
crates/ruff_python_parser/src/parser/expression.rs
View file

@ -875,7 +875,16 @@ impl<'src> Parser<'src> {
// test_err star_slices // test_err star_slices
// array[*start:*end] // array[*start:*end]
if let Expr::Tuple(ast::ExprTuple { elts, .. }) = &slice {
// test_ok parenthesized_star_index_py310
// # parse_options: {"target-version": "3.10"}
// out[(*(slice(None) for _ in range(2)), *ind)] = 1
if let Expr::Tuple(ast::ExprTuple {
elts,
parenthesized: false,
..
}) = &slice
{
for elt in elts.iter().filter(|elt| elt.is_starred_expr()) { for elt in elts.iter().filter(|elt| elt.is_starred_expr()) {
self.add_unsupported_syntax_error( self.add_unsupported_syntax_error(
UnsupportedSyntaxErrorKind::StarExpressionInIndex, UnsupportedSyntaxErrorKind::StarExpressionInIndex,

141
crates/ruff_python_parser/tests/snapshots/valid_syntax@parenthesized_star_index_py310.py.snap Normal file
View file

@ -0,0 +1,141 @@
---
source: crates/ruff_python_parser/tests/fixtures.rs
input_file: crates/ruff_python_parser/resources/inline/ok/parenthesized_star_index_py310.py
snapshot_kind: text
---
## AST
```
Module(
ModModule {
range: 0..94,
body: [
Assign(
StmtAssign {
range: 44..93,
targets: [
Subscript(
ExprSubscript {
range: 44..89,
value: Name(
ExprName {
range: 44..47,
id: Name("out"),
ctx: Load,
},
),
slice: Tuple(
ExprTuple {
range: 48..88,
elts: [
Starred(
ExprStarred {
range: 49..81,
value: Generator(
ExprGenerator {
range: 50..81,
elt: Call(
ExprCall {
range: 51..62,
func: Name(
ExprName {
range: 51..56,
id: Name("slice"),
ctx: Load,
},
),
arguments: Arguments {
range: 56..62,
args: [
NoneLiteral(
ExprNoneLiteral {
range: 57..61,
},
),
],
keywords: [],
},
},
),
generators: [
Comprehension {
range: 63..80,
target: Name(
ExprName {
range: 67..68,
id: Name("_"),
ctx: Store,
},
),
iter: Call(
ExprCall {
range: 72..80,
func: Name(
ExprName {
range: 72..77,
id: Name("range"),
ctx: Load,
},
),
arguments: Arguments {
range: 77..80,
args: [
NumberLiteral(
ExprNumberLiteral {
range: 78..79,
value: Int(
2,
),
},
),
],
keywords: [],
},
},
),
ifs: [],
is_async: false,
},
],
parenthesized: true,
},
),
ctx: Load,
},
),
Starred(
ExprStarred {
range: 83..87,
value: Name(
ExprName {
range: 84..87,
id: Name("ind"),
ctx: Load,
},
),
ctx: Load,
},
),
],
ctx: Load,
parenthesized: true,
},
),
ctx: Store,
},
),
],
value: NumberLiteral(
ExprNumberLiteral {
range: 92..93,
value: Int(
1,
),
},
),
},
),
],
},
)
```