language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-02 22:55:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[flake8-pie] Allow cast(SomeType, ...) (PIE796) (#15141)

Browse source
This commit is contained in:
InSync 2024-12-30 21:52:35 +07:00 • committed by GitHub
parent 04d538113a
commit 280ba75100
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 64 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

39
crates/ruff_linter/src/rules/flake8_pie/rules/non_unique_enums.rs
View file

@ -4,7 +4,7 @@ use ruff_diagnostics::Diagnostic;
use ruff_diagnostics::Violation;
use ruff_macros::{derive_message_formats, ViolationMetadata};
use ruff_python_ast::comparable::ComparableExpr;
use ruff_python_ast::{self as ast, Expr, PySourceType, Stmt};
use ruff_python_ast::{self as ast, Expr, ExprCall, Stmt};
use ruff_text_size::Ranged;
use crate::checkers::ast::Checker;
@ -55,13 +55,14 @@ impl Violation for NonUniqueEnums {
/// PIE796
pub(crate) fn non_unique_enums(checker: &mut Checker, parent: &Stmt, body: &[Stmt]) {
let semantic = checker.semantic();
let Stmt::ClassDef(parent) = parent else {
return;
};
if !parent.bases().iter().any(|expr| {
checker
.semantic()
semantic
.resolve_qualified_name(expr)
.is_some_and(|qualified_name| matches!(qualified_name.segments(), ["enum", "Enum"]))
}) {
@ -84,14 +85,12 @@ pub(crate) fn non_unique_enums(checker: &mut Checker, parent: &Stmt, body: &[Stm
}
}
let comparable = ComparableExpr::from(value);
if checker.source_type == PySourceType::Stub
&& comparable == ComparableExpr::EllipsisLiteral
{
if checker.source_type.is_stub() && member_has_unknown_value(checker, value) {
continue;
}
let comparable = ComparableExpr::from(value);
if !seen_targets.insert(comparable) {
let diagnostic = Diagnostic::new(
NonUniqueEnums {
@ -103,3 +102,27 @@ pub(crate) fn non_unique_enums(checker: &mut Checker, parent: &Stmt, body: &[Stm
}
}
}
/// Whether the value is a bare ellipsis literal (`A = ...`)
/// or a casted one (`A = cast(SomeType, ...)`).
fn member_has_unknown_value(checker: &Checker, expr: &Expr) -> bool {
match expr {
Expr::EllipsisLiteral(_) => true,
Expr::Call(ExprCall {
func, arguments, ..
}) => {
if !checker.semantic().match_typing_expr(func, "cast") {
return false;
}
if !arguments.keywords.is_empty() {
return false;
}
matches!(arguments.args.as_ref(), [_, Expr::EllipsisLiteral(_)])
}
_ => false,
}
}

17
crates/ruff_linter/src/rules/flake8_pie/snapshots/ruff_linter__rules__flake8_pie__tests__PIE796_PIE796.py.snap
View file

@ -74,3 +74,20 @@ PIE796.py:72:5: PIE796 Enum contains duplicate value: `...`
72 | C = ... # PIE796
| ^^^^^^^ PIE796
|
PIE796.py:79:5: PIE796 Enum contains duplicate value: `cast(SomeType, ...)`
|
77 | class FakeEnum11(enum.Enum):
78 | A = cast(SomeType, ...)
79 | B = cast(SomeType, ...) # PIE796
| ^^^^^^^^^^^^^^^^^^^^^^^ PIE796
80 | C = cast(SomeType, ...) # PIE796
|
PIE796.py:80:5: PIE796 Enum contains duplicate value: `cast(SomeType, ...)`
|
78 | A = cast(SomeType, ...)
79 | B = cast(SomeType, ...) # PIE796
80 | C = cast(SomeType, ...) # PIE796
| ^^^^^^^^^^^^^^^^^^^^^^^ PIE796
|