language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-27 20:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

ruff: add worktree support to build.rs (#14896)

Browse source 
Without this, `cargo insta test` re-compiles every time it is run, even
if there are no changes. With this, I can re-run `cargo insta test` (or
other `cargo build` commands) without it resulting in re-compiles.

I made an identical change to uv a while back:
https://github.com/astral-sh/uv/pull/6825
This commit is contained in:
Andrew Gallant 2024-12-10 14:06:59 -05:00 • committed by GitHub
parent 5fc8e5d80e
commit 2ecd164adb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 47 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

68
crates/ruff/build.rs
View file

@ -1,4 +1,8 @@
use std::{fs, path::Path, process::Command}; use std::{
fs,
path::{Path, PathBuf},
process::Command,
};
fn main() { fn main() {
// The workspace root directory is not available without walking up the tree // The workspace root directory is not available without walking up the tree
@ -21,27 +25,22 @@ fn commit_info(workspace_root: &Path) {
return; return;
} }
let git_head_path = git_dir.join("HEAD"); if let Some(git_head_path) = git_head(&git_dir) {
println!( println!("cargo:rerun-if-changed={}", git_head_path.display());
"cargo::rerun-if-changed={}",
git_head_path.as_path().display()
);
let git_head_contents = fs::read_to_string(git_head_path); let git_head_contents = fs::read_to_string(git_head_path);
if let Ok(git_head_contents) = git_head_contents { if let Ok(git_head_contents) = git_head_contents {
// The contents are either a commit or a reference in the following formats // The contents are either a commit or a reference in the following formats
// - "<commit>" when the head is detached // - "<commit>" when the head is detached
// - "ref <ref>" when working on a branch // - "ref <ref>" when working on a branch
// If a commit, checking if the HEAD file has changed is sufficient // If a commit, checking if the HEAD file has changed is sufficient
// If a ref, we need to add the head file for that ref to rebuild on commit // If a ref, we need to add the head file for that ref to rebuild on commit
let mut git_ref_parts = git_head_contents.split_whitespace(); let mut git_ref_parts = git_head_contents.split_whitespace();
git_ref_parts.next(); git_ref_parts.next();
if let Some(git_ref) = git_ref_parts.next() { if let Some(git_ref) = git_ref_parts.next() {
let git_ref_path = git_dir.join(git_ref); let git_ref_path = git_dir.join(git_ref);
println!( println!("cargo:rerun-if-changed={}", git_ref_path.display());
"cargo::rerun-if-changed={}", }
git_ref_path.as_path().display()
);
} }
} }
@ -78,3 +77,30 @@ fn commit_info(workspace_root: &Path) {
); );
} }
} }
fn git_head(git_dir: &Path) -> Option<PathBuf> {
// The typical case is a standard git repository.
let git_head_path = git_dir.join("HEAD");
if git_head_path.exists() {
return Some(git_head_path);
}
if !git_dir.is_file() {
return None;
}
// If `.git/HEAD` doesn't exist and `.git` is actually a file,
// then let's try to attempt to read it as a worktree. If it's
// a worktree, then its contents will look like this, e.g.:
//
// gitdir: /home/andrew/astral/uv/main/.git/worktrees/pr2
//
// And the HEAD file we want to watch will be at:
//
// /home/andrew/astral/uv/main/.git/worktrees/pr2/HEAD
let contents = fs::read_to_string(git_dir).ok()?;
let (label, worktree_path) = contents.split_once(':')?;
if label != "gitdir" {
return None;
}
let worktree_path = worktree_path.trim();
Some(PathBuf::from(worktree_path))
}