language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 05:45:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Fix duplicate diagnostics for unresolved module when an import from statement imports multiple members (#17886)

Browse source
This commit is contained in:
Alex Waygood 2025-05-06 12:37:10 +01:00 • committed by GitHub
parent 457ec4dddd
commit 2f9992b6ef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 95 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

18
crates/ty_python_semantic/resources/mdtest/import/basic.md
View file

@ -121,7 +121,7 @@ class C: ...
<!-- snapshot-diagnostics -->
```py
import zqzqzqzqzqzqzq # error: [unresolved-import] "Cannot resolve import `zqzqzqzqzqzqzq`"
import zqzqzqzqzqzqzq # error: [unresolved-import] "Cannot resolve imported module `zqzqzqzqzqzqzq`"
```
## Unresolvable submodule imports
@ -130,10 +130,10 @@ import zqzqzqzqzqzqzq # error: [unresolved-import] "Cannot resolve import `zqzq
```py
# Topmost component resolvable, submodule not resolvable:
import a.foo # error: [unresolved-import] "Cannot resolve import `a.foo`"
import a.foo # error: [unresolved-import] "Cannot resolve imported module `a.foo`"
# Topmost component unresolvable:
import b.foo # error: [unresolved-import] "Cannot resolve import `b.foo`"
import b.foo # error: [unresolved-import] "Cannot resolve imported module `b.foo`"
```
`a/__init__.py`:
@ -164,3 +164,15 @@ from AveryLongPathAveryLongPathAveryLongPathAveryLongPathAveryLongPathAveryLongP
reveal_type(Foo()) # revealed: Foo
```
## Multiple objects imported from an unresolved module
<!-- snapshot-diagnostics -->
If multiple members are imported from a module that cannot be resolved, only a single diagnostic is
emitted for the `import from` statement:
```py
# error: [unresolved-import]
from does_not_exist import foo, bar, baz
```