From 315fb0f3da4e5f2097a294c344025dec28ebf2a5 Mon Sep 17 00:00:00 2001 From: GiGaGon <107241144+MeGaGiGaGon@users.noreply.github.com> Date: Mon, 23 Jun 2025 06:23:01 -0700 Subject: [PATCH] [`flake8-logging`] Add fix safety section to `LOG002` (#18840) ## Summary Part of #15584 This adds a `Fix safety` section to [invalid-get-logger-argument (LOG002)](https://docs.astral.sh/ruff/rules/invalid-get-logger-argument/#invalid-get-logger-argument-log002). The fix/lint was introduced in #7399 No reasoning is given on the unsafety in the PR/code Unsafe fix demonstration: [playground](https://play.ruff.rs/e8008cbf-2ef5-4d38-8255-324f90e624cb) ```py import logging logger = logging.getLogger(__file__) ``` --------- Co-authored-by: Dylan --- .../rules/flake8_logging/rules/invalid_get_logger_argument.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/ruff_linter/src/rules/flake8_logging/rules/invalid_get_logger_argument.rs b/crates/ruff_linter/src/rules/flake8_logging/rules/invalid_get_logger_argument.rs index 17c8ad8676..368bdfa5d0 100644 --- a/crates/ruff_linter/src/rules/flake8_logging/rules/invalid_get_logger_argument.rs +++ b/crates/ruff_linter/src/rules/flake8_logging/rules/invalid_get_logger_argument.rs @@ -39,6 +39,10 @@ use crate::{Edit, Fix, FixAvailability, Violation}; /// logger = logging.getLogger(__name__) /// ``` /// +/// ## Fix safety +/// This fix is always unsafe, as changing the arguments to `getLogger` can change the +/// received logger object, and thus program behavior. +/// /// [logging documentation]: https://docs.python.org/3/library/logging.html#logger-objects #[derive(ViolationMetadata)] pub(crate) struct InvalidGetLoggerArgument;