language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 18:58:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Check LinterSettings::preview for version-related syntax errors (#16429)

Browse source
This commit is contained in:
Brent Westbrook 2025-02-28 03:58:22 -05:00 • committed by GitHub
parent 4a23756024
commit 3d72138740
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/ruff_server/src/lint.rs
View file

@ -172,6 +172,12 @@ pub(crate) fn check(
)
});
let unsupported_syntax_errors = if settings.linter.preview.is_enabled() {
parsed.unsupported_syntax_errors()
} else {
&[]
};
let lsp_diagnostics = lsp_diagnostics.chain(
show_syntax_errors
.then(|| {
@ -186,7 +192,7 @@ pub(crate) fn check(
encoding,
)
})
.chain(parsed.unsupported_syntax_errors().iter().map(|error| {
.chain(unsupported_syntax_errors.iter().map(|error| {
unsupported_syntax_error_to_lsp_diagnostic(
error,
&source_kind,

8
crates/ruff_wasm/src/lib.rs
View file

@ -205,6 +205,12 @@ impl Workspace {
let source_code = locator.to_source_code();
let unsupported_syntax_errors = if self.settings.linter.preview.is_enabled() {
parsed.unsupported_syntax_errors()
} else {
&[]
};
let messages: Vec<ExpandedMessage> = diagnostics
.into_iter()
.map(|diagnostic| {
@ -242,7 +248,7 @@ impl Workspace {
fix: None,
}
}))
.chain(parsed.unsupported_syntax_errors().iter().map(|error| {
.chain(unsupported_syntax_errors.iter().map(|error| {
let start_location = source_code.source_location(error.range.start());
let end_location = source_code.source_location(error.range.end());

2
crates/ruff_wasm/tests/api.rs
View file

@ -65,7 +65,7 @@ fn syntax_error() {
fn unsupported_syntax_error() {
check!(
"match 2:\n case 1: ...",
r#"{}"#,
r#"{"preview": true}"#,
[ExpandedMessage {
code: None,
message: "SyntaxError: Cannot use `match` statement on Python 3.9 (syntax was added in Python 3.10)".to_string(),