mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-28 21:05:08 +00:00
Use trait for labels instead of TypeId
(#5270)
This commit is contained in:
parent
1eccbbb60e
commit
3d7411bfaf
2 changed files with 48 additions and 25 deletions
|
@ -1,8 +1,5 @@
|
|||
use crate::format_element::PrintMode;
|
||||
use crate::{GroupId, TextSize};
|
||||
#[cfg(debug_assertions)]
|
||||
use std::any::type_name;
|
||||
use std::any::TypeId;
|
||||
use std::cell::Cell;
|
||||
use std::num::NonZeroU8;
|
||||
|
||||
|
@ -235,37 +232,48 @@ impl Align {
|
|||
}
|
||||
}
|
||||
|
||||
#[derive(Eq, PartialEq, Copy, Clone)]
|
||||
#[derive(Debug, Eq, Copy, Clone)]
|
||||
pub struct LabelId {
|
||||
id: TypeId,
|
||||
value: u64,
|
||||
#[cfg(debug_assertions)]
|
||||
label: &'static str,
|
||||
name: &'static str,
|
||||
}
|
||||
|
||||
#[cfg(debug_assertions)]
|
||||
impl std::fmt::Debug for LabelId {
|
||||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
||||
f.write_str(self.label)
|
||||
}
|
||||
}
|
||||
impl PartialEq for LabelId {
|
||||
fn eq(&self, other: &Self) -> bool {
|
||||
let is_equal = self.value == other.value;
|
||||
|
||||
#[cfg(not(debug_assertions))]
|
||||
impl std::fmt::Debug for LabelId {
|
||||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
||||
std::write!(f, "#{:?}", self.id)
|
||||
#[cfg(debug_assertions)]
|
||||
{
|
||||
if is_equal {
|
||||
assert_eq!(self.name, other.name, "Two `LabelId`s with different names have the same `value`. Are you mixing labels of two different `LabelDefinition` or are the values returned by the `LabelDefinition` not unique?");
|
||||
}
|
||||
}
|
||||
|
||||
is_equal
|
||||
}
|
||||
}
|
||||
|
||||
impl LabelId {
|
||||
pub fn of<T: ?Sized + 'static>() -> Self {
|
||||
pub fn of<T: LabelDefinition>(label: T) -> Self {
|
||||
Self {
|
||||
id: TypeId::of::<T>(),
|
||||
value: label.value(),
|
||||
#[cfg(debug_assertions)]
|
||||
label: type_name::<T>(),
|
||||
name: label.name(),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Defines the valid labels of a language. You want to have at most one implementation per formatter
|
||||
/// project.
|
||||
pub trait LabelDefinition {
|
||||
/// Returns the `u64` uniquely identifying this specific label.
|
||||
fn value(&self) -> u64;
|
||||
|
||||
/// Returns the name of the label that is shown in debug builds.
|
||||
fn name(&self) -> &'static str;
|
||||
}
|
||||
|
||||
#[derive(Clone, Copy, Eq, PartialEq, Debug)]
|
||||
pub enum VerbatimKind {
|
||||
Bogus,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue