language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-19 10:01:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[pylint] - remove AugAssign errors from self-cls-assignment (W0642) (#12957)

Browse source
This commit is contained in:
Steve C 2024-08-18 11:31:09 -04:00 • committed by GitHub
parent 81a2220ce1
commit 4881d32c80
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ruff_linter/resources/test/fixtures/pylint/self_or_cls_assignment.py vendored
View file

@ -3,7 +3,7 @@ class Fruit:
def list_fruits(cls) -> None: def list_fruits(cls) -> None:
cls = "apple" # PLW0642 cls = "apple" # PLW0642
cls: Fruit = "apple" # PLW0642 cls: Fruit = "apple" # PLW0642
cls += "orange" # PLW0642 cls += "orange" # OK, augmented assignments are ignored
*cls = "banana" # PLW0642 *cls = "banana" # PLW0642
cls, blah = "apple", "orange" # PLW0642 cls, blah = "apple", "orange" # PLW0642
blah, (cls, blah2) = "apple", ("orange", "banana") # PLW0642 blah, (cls, blah2) = "apple", ("orange", "banana") # PLW0642
@ -16,7 +16,7 @@ class Fruit:
def print_color(self) -> None: def print_color(self) -> None:
self = "red" # PLW0642 self = "red" # PLW0642
self: Self = "red" # PLW0642 self: Self = "red" # PLW0642
self += "blue" # PLW0642 self += "blue" # OK, augmented assignments are ignored
*self = "blue" # PLW0642 *self = "blue" # PLW0642
self, blah = "red", "blue" # PLW0642 self, blah = "red", "blue" # PLW0642
blah, (self, blah2) = "apple", ("orange", "banana") # PLW0642 blah, (self, blah2) = "apple", ("orange", "banana") # PLW0642

3
crates/ruff_linter/src/checkers/ast/analyze/statement.rs
View file

@ -1112,9 +1112,6 @@ pub(crate) fn statement(stmt: &Stmt, checker: &mut Checker) {
} }
} }
Stmt::AugAssign(aug_assign @ ast::StmtAugAssign { target, .. }) => { Stmt::AugAssign(aug_assign @ ast::StmtAugAssign { target, .. }) => {
if checker.enabled(Rule::SelfOrClsAssignment) {
pylint::rules::self_or_cls_assignment(checker, target);
}
if checker.enabled(Rule::GlobalStatement) { if checker.enabled(Rule::GlobalStatement) {
if let Expr::Name(ast::ExprName { id, .. }) = target.as_ref() { if let Expr::Name(ast::ExprName { id, .. }) = target.as_ref() {
pylint::rules::global_statement(checker, id); pylint::rules::global_statement(checker, id);

38
crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLW0642_self_or_cls_assignment.py.snap
View file

@ -8,7 +8,7 @@ self_or_cls_assignment.py:4:9: PLW0642 Reassigned `cls` variable in class method
4 | cls = "apple" # PLW0642 4 | cls = "apple" # PLW0642
| ^^^ PLW0642 | ^^^ PLW0642
5 | cls: Fruit = "apple" # PLW0642 5 | cls: Fruit = "apple" # PLW0642
6 | cls += "orange" # PLW0642 6 | cls += "orange" # OK, augmented assignments are ignored
| |
= help: Consider using a different variable name = help: Consider using a different variable name
@ -18,26 +18,15 @@ self_or_cls_assignment.py:5:9: PLW0642 Reassigned `cls` variable in class method
4 | cls = "apple" # PLW0642 4 | cls = "apple" # PLW0642
5 | cls: Fruit = "apple" # PLW0642 5 | cls: Fruit = "apple" # PLW0642
| ^^^ PLW0642 | ^^^ PLW0642
6 | cls += "orange" # PLW0642 6 | cls += "orange" # OK, augmented assignments are ignored
7 | *cls = "banana" # PLW0642 7 | *cls = "banana" # PLW0642
| |
= help: Consider using a different variable name = help: Consider using a different variable name
self_or_cls_assignment.py:6:9: PLW0642 Reassigned `cls` variable in class method
|
4 | cls = "apple" # PLW0642
5 | cls: Fruit = "apple" # PLW0642
6 | cls += "orange" # PLW0642
| ^^^ PLW0642
7 | *cls = "banana" # PLW0642
8 | cls, blah = "apple", "orange" # PLW0642
|
= help: Consider using a different variable name
self_or_cls_assignment.py:7:10: PLW0642 Reassigned `cls` variable in class method self_or_cls_assignment.py:7:10: PLW0642 Reassigned `cls` variable in class method
| |
5 | cls: Fruit = "apple" # PLW0642 5 | cls: Fruit = "apple" # PLW0642
6 | cls += "orange" # PLW0642 6 | cls += "orange" # OK, augmented assignments are ignored
7 | *cls = "banana" # PLW0642 7 | *cls = "banana" # PLW0642
| ^^^ PLW0642 | ^^^ PLW0642
8 | cls, blah = "apple", "orange" # PLW0642 8 | cls, blah = "apple", "orange" # PLW0642
@ -47,7 +36,7 @@ self_or_cls_assignment.py:7:10: PLW0642 Reassigned `cls` variable in class metho
self_or_cls_assignment.py:8:9: PLW0642 Reassigned `cls` variable in class method self_or_cls_assignment.py:8:9: PLW0642 Reassigned `cls` variable in class method
| |
6 | cls += "orange" # PLW0642 6 | cls += "orange" # OK, augmented assignments are ignored
7 | *cls = "banana" # PLW0642 7 | *cls = "banana" # PLW0642
8 | cls, blah = "apple", "orange" # PLW0642 8 | cls, blah = "apple", "orange" # PLW0642
| ^^^ PLW0642 | ^^^ PLW0642
@ -94,7 +83,7 @@ self_or_cls_assignment.py:17:9: PLW0642 Reassigned `self` variable in instance m
17 | self = "red" # PLW0642 17 | self = "red" # PLW0642
| ^^^^ PLW0642 | ^^^^ PLW0642
18 | self: Self = "red" # PLW0642 18 | self: Self = "red" # PLW0642
19 | self += "blue" # PLW0642 19 | self += "blue" # OK, augmented assignments are ignored
| |
= help: Consider using a different variable name = help: Consider using a different variable name
@ -104,26 +93,15 @@ self_or_cls_assignment.py:18:9: PLW0642 Reassigned `self` variable in instance m
17 | self = "red" # PLW0642 17 | self = "red" # PLW0642
18 | self: Self = "red" # PLW0642 18 | self: Self = "red" # PLW0642
| ^^^^ PLW0642 | ^^^^ PLW0642
19 | self += "blue" # PLW0642 19 | self += "blue" # OK, augmented assignments are ignored
20 | *self = "blue" # PLW0642 20 | *self = "blue" # PLW0642
| |
= help: Consider using a different variable name = help: Consider using a different variable name
self_or_cls_assignment.py:19:9: PLW0642 Reassigned `self` variable in instance method
|
17 | self = "red" # PLW0642
18 | self: Self = "red" # PLW0642
19 | self += "blue" # PLW0642
| ^^^^ PLW0642
20 | *self = "blue" # PLW0642
21 | self, blah = "red", "blue" # PLW0642
|
= help: Consider using a different variable name
self_or_cls_assignment.py:20:10: PLW0642 Reassigned `self` variable in instance method self_or_cls_assignment.py:20:10: PLW0642 Reassigned `self` variable in instance method
| |
18 | self: Self = "red" # PLW0642 18 | self: Self = "red" # PLW0642
19 | self += "blue" # PLW0642 19 | self += "blue" # OK, augmented assignments are ignored
20 | *self = "blue" # PLW0642 20 | *self = "blue" # PLW0642
| ^^^^ PLW0642 | ^^^^ PLW0642
21 | self, blah = "red", "blue" # PLW0642 21 | self, blah = "red", "blue" # PLW0642
@ -133,7 +111,7 @@ self_or_cls_assignment.py:20:10: PLW0642 Reassigned `self` variable in instance
self_or_cls_assignment.py:21:9: PLW0642 Reassigned `self` variable in instance method self_or_cls_assignment.py:21:9: PLW0642 Reassigned `self` variable in instance method
| |
19 | self += "blue" # PLW0642 19 | self += "blue" # OK, augmented assignments are ignored
20 | *self = "blue" # PLW0642 20 | *self = "blue" # PLW0642
21 | self, blah = "red", "blue" # PLW0642 21 | self, blah = "red", "blue" # PLW0642
| ^^^^ PLW0642 | ^^^^ PLW0642