Avoid trimming docstring if ends in trailing quote (#2025)

Closes #2017.

resources/test/fixtures/pydocstyle/D.py

@@ -606,3 +606,12 @@ def one_liner():
     r"""Wrong.
 
     """
+
+
+@expect('D200: One-line docstring should fit on one line with quotes '
+        '(found 3)')
+@expect('D212: Multi-line docstring summary should start at the first line')
+def one_liner():
+    """Wrong."
+
+    """

src/rules/pydocstyle/rules/no_surrounding_whitespace.rs

@@ -30,22 +30,20 @@ pub fn no_surrounding_whitespace(checker: &mut Checker, docstring: &Docstring) {
     );
     if checker.patch(diagnostic.kind.rule()) {
         if let Some(pattern) = leading_quote(contents) {
-            if let Some(quote) = pattern.chars().last() {
-                // If removing whitespace would lead to an invalid string of quote
-                // characters, avoid applying the fix.
-                if !trimmed.ends_with(quote) {
-                    diagnostic.amend(Fix::replacement(
-                        trimmed.to_string(),
-                        Location::new(
-                            docstring.expr.location.row(),
-                            docstring.expr.location.column() + pattern.len(),
-                        ),
-                        Location::new(
-                            docstring.expr.location.row(),
-                            docstring.expr.location.column() + pattern.len() + line.chars().count(),
-                        ),
-                    ));
-                }
+            // If removing whitespace would lead to an invalid string of quote
+            // characters, avoid applying the fix.
+            if !trimmed.ends_with(pattern.chars().last().unwrap()) {
+                diagnostic.amend(Fix::replacement(
+                    trimmed.to_string(),
+                    Location::new(
+                        docstring.expr.location.row(),
+                        docstring.expr.location.column() + pattern.len(),
+                    ),
+                    Location::new(
+                        docstring.expr.location.row(),
+                        docstring.expr.location.column() + pattern.len() + line.chars().count(),
+                    ),
+                ));
             }
         }
     }

src/rules/pydocstyle/rules/one_liner.rs

@@ -31,11 +31,16 @@ pub fn one_liner(checker: &mut Checker, docstring: &Docstring) {
                 helpers::leading_quote(docstring.contents),
                 helpers::trailing_quote(docstring.contents),
             ) {
-                diagnostic.amend(Fix::replacement(
-                    format!("{leading}{}{trailing}", docstring.body.trim()),
-                    docstring.expr.location,
-                    docstring.expr.end_location.unwrap(),
-                ));
+                // If removing whitespace would lead to an invalid string of quote
+                // characters, avoid applying the fix.
+                let trimmed = docstring.body.trim();
+                if !trimmed.ends_with(trailing.chars().last().unwrap()) {
+                    diagnostic.amend(Fix::replacement(
+                        format!("{leading}{trimmed}{trailing}"),
+                        docstring.expr.location,
+                        docstring.expr.end_location.unwrap(),
+                    ));
+                }
             }
         }
         checker.diagnostics.push(diagnostic);

src/rules/pydocstyle/snapshots/ruff__rules__pydocstyle__tests__D200_D.py.snap

@@ -53,4 +53,14 @@ expression: diagnostics
       row: 608
       column: 7
   parent: ~
+- kind:
+    FitsOnOneLine: ~
+  location:
+    row: 615
+    column: 4
+  end_location:
+    row: 617
+    column: 7
+  fix: ~
+  parent: ~
 

src/rules/pydocstyle/snapshots/ruff__rules__pydocstyle__tests__D213_D.py.snap

@@ -212,4 +212,14 @@ expression: diagnostics
     column: 7
   fix: ~
   parent: ~
+- kind:
+    MultiLineSummarySecondLine: ~
+  location:
+    row: 615
+    column: 4
+  end_location:
+    row: 617
+    column: 7
+  fix: ~
+  parent: ~
 

src/rules/pydocstyle/snapshots/ruff__rules__pydocstyle__tests__D400_D.py.snap

@@ -240,4 +240,21 @@ expression: diagnostics
       row: 581
       column: 47
   parent: ~
+- kind:
+    EndsInPeriod: ~
+  location:
+    row: 615
+    column: 4
+  end_location:
+    row: 617
+    column: 7
+  fix:
+    content: "."
+    location:
+      row: 615
+      column: 14
+    end_location:
+      row: 615
+      column: 14
+  parent: ~
 

src/rules/pydocstyle/snapshots/ruff__rules__pydocstyle__tests__D415_D.py.snap

@@ -223,4 +223,21 @@ expression: diagnostics
       row: 581
       column: 47
   parent: ~
+- kind:
+    EndsInPunctuation: ~
+  location:
+    row: 615
+    column: 4
+  end_location:
+    row: 617
+    column: 7
+  fix:
+    content: "."
+    location:
+      row: 615
+      column: 14
+    end_location:
+      row: 615
+      column: 14
+  parent: ~