diff --git a/crates/ruff/resources/test/fixtures/flake8_no_pep420/test_pass_script/script b/crates/ruff/resources/test/fixtures/flake8_no_pep420/test_pass_script/script new file mode 100755 index 0000000000..9e8ac2ebe5 --- /dev/null +++ b/crates/ruff/resources/test/fixtures/flake8_no_pep420/test_pass_script/script @@ -0,0 +1,3 @@ +#!/usr/bin/env python3 + +print("Hello, INP001!") diff --git a/crates/ruff/src/rules/flake8_no_pep420/mod.rs b/crates/ruff/src/rules/flake8_no_pep420/mod.rs index c8fbdba876..d38c5d2262 100644 --- a/crates/ruff/src/rules/flake8_no_pep420/mod.rs +++ b/crates/ruff/src/rules/flake8_no_pep420/mod.rs @@ -20,6 +20,7 @@ mod tests { #[test_case(Path::new("test_ignored"), Path::new("example.py"); "INP001_4")] #[test_case(Path::new("test_pass_namespace_package"), Path::new("example.py"); "INP001_5")] #[test_case(Path::new("test_pass_pyi"), Path::new("example.pyi"); "INP001_6")] + #[test_case(Path::new("test_pass_script"), Path::new("script"); "INP001_7")] fn test_flake8_no_pep420(path: &Path, filename: &Path) -> Result<()> { let snapshot = format!("{}", path.to_string_lossy()); let p = PathBuf::from(format!( diff --git a/crates/ruff/src/rules/flake8_no_pep420/rules.rs b/crates/ruff/src/rules/flake8_no_pep420/rules.rs index 5a0b3f2040..767eb055ac 100644 --- a/crates/ruff/src/rules/flake8_no_pep420/rules.rs +++ b/crates/ruff/src/rules/flake8_no_pep420/rules.rs @@ -26,8 +26,8 @@ pub fn implicit_namespace_package( src: &[PathBuf], ) -> Option { if package.is_none() - // Ignore `.pyi` files, which don't require an `__init__.py`. - && path.extension().map_or(true, |ext| ext != "pyi") + // Ignore non-`.py` files, which don't require an `__init__.py`. + && path.extension().map_or(false, |ext| ext == "py") // Ignore any files that are direct children of the project root. && !path .parent() diff --git a/crates/ruff/src/rules/flake8_no_pep420/snapshots/ruff__rules__flake8_no_pep420__tests__test_pass_script.snap b/crates/ruff/src/rules/flake8_no_pep420/snapshots/ruff__rules__flake8_no_pep420__tests__test_pass_script.snap new file mode 100644 index 0000000000..b25a9aa1ca --- /dev/null +++ b/crates/ruff/src/rules/flake8_no_pep420/snapshots/ruff__rules__flake8_no_pep420__tests__test_pass_script.snap @@ -0,0 +1,6 @@ +--- +source: crates/ruff/src/rules/flake8_no_pep420/mod.rs +expression: diagnostics +--- +[] +