Run nightly Clippy over the Ruff repo (#5670)

## Summary

This is the result of running `cargo +nightly clippy --workspace
--all-targets --all-features -- -D warnings` and fixing all violations.
Just wanted to see if there were any interesting new checks on nightly
👀
This commit is contained in:
Charlie Marsh 2023-07-10 23:44:38 -04:00 committed by GitHub
parent e7e2f44440
commit 4dee49d6fa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
40 changed files with 220 additions and 470 deletions

View file

@ -66,7 +66,7 @@ impl Fix {
)]
pub fn unspecified_edits(edit: Edit, rest: impl IntoIterator<Item = Edit>) -> Self {
Self {
edits: std::iter::once(edit).chain(rest.into_iter()).collect(),
edits: std::iter::once(edit).chain(rest).collect(),
applicability: Applicability::Unspecified,
isolation_level: IsolationLevel::default(),
}
@ -84,7 +84,7 @@ impl Fix {
/// Create a new [`Fix`] with [automatic applicability](Applicability::Automatic) from multiple [`Edit`] elements.
pub fn automatic_edits(edit: Edit, rest: impl IntoIterator<Item = Edit>) -> Self {
Self {
edits: std::iter::once(edit).chain(rest.into_iter()).collect(),
edits: std::iter::once(edit).chain(rest).collect(),
applicability: Applicability::Automatic,
isolation_level: IsolationLevel::default(),
}
@ -102,7 +102,7 @@ impl Fix {
/// Create a new [`Fix`] with [suggested applicability](Applicability::Suggested) from multiple [`Edit`] elements.
pub fn suggested_edits(edit: Edit, rest: impl IntoIterator<Item = Edit>) -> Self {
Self {
edits: std::iter::once(edit).chain(rest.into_iter()).collect(),
edits: std::iter::once(edit).chain(rest).collect(),
applicability: Applicability::Suggested,
isolation_level: IsolationLevel::default(),
}
@ -120,7 +120,7 @@ impl Fix {
/// Create a new [`Fix`] with [manual applicability](Applicability::Manual) from multiple [`Edit`] elements.
pub fn manual_edits(edit: Edit, rest: impl IntoIterator<Item = Edit>) -> Self {
Self {
edits: std::iter::once(edit).chain(rest.into_iter()).collect(),
edits: std::iter::once(edit).chain(rest).collect(),
applicability: Applicability::Manual,
isolation_level: IsolationLevel::default(),
}