language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-09 21:28:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Use const-singleton helpers in more rules (#5142)

Browse source
This commit is contained in:
Charlie Marsh 2023-06-16 00:28:35 -04:00 • committed by GitHub
parent fab2a4adf7
commit 5526699535
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 37 additions and 107 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/ruff_python_semantic/src/analyze/typing.rs
View file

@ -1,9 +1,10 @@
//! Analysis rules for the `typing` module.
use num_traits::identities::Zero;
use rustpython_parser::ast::{self, Constant, Expr, Operator};
use num_traits::identities::Zero;
use ruff_python_ast::call_path::{from_qualified_name, from_unqualified_name, CallPath};
use ruff_python_ast::helpers::is_const_false;
use ruff_python_stdlib::typing::{
IMMUTABLE_GENERIC_TYPES, IMMUTABLE_TYPES, PEP_585_GENERICS, PEP_593_SUBSCRIPTS, SUBSCRIPTS,
};
@ -267,13 +268,7 @@ pub fn is_type_checking_block(stmt: &ast::StmtIf, semantic: &SemanticModel) -> b
let ast::StmtIf { test, .. } = stmt;
// Ex) `if False:`
if matches!(
test.as_ref(),
Expr::Constant(ast::ExprConstant {
value: Constant::Bool(false),
..
})
) {
if is_const_false(test) {
return true;
}