language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-01 06:11:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Use .as_ref() in lieu of &** (#5874)

Browse source 
I find this less opaque (and often more succinct).
This commit is contained in:
Charlie Marsh 2023-07-18 20:49:13 -04:00 • committed by GitHub
parent 7ffcd93afd
commit 626d8dc2cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 17 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/ruff_python_ast/src/comparable.rs
View file

@ -274,7 +274,7 @@ impl<'a> From<&'a ast::Pattern> for ComparablePattern<'a> {
impl<'a> From<&'a Box<ast::Pattern>> for Box<ComparablePattern<'a>> {
fn from(pattern: &'a Box<ast::Pattern>) -> Self {
Box::new((&**pattern).into())
Box::new((pattern.as_ref()).into())
}
}
@ -362,13 +362,13 @@ impl<'a> From<&'a ast::Arguments> for ComparableArguments<'a> {
impl<'a> From<&'a Box<ast::Arguments>> for ComparableArguments<'a> {
fn from(arguments: &'a Box<ast::Arguments>) -> Self {
(&**arguments).into()
(arguments.as_ref()).into()
}
}
impl<'a> From<&'a Box<ast::Arg>> for ComparableArg<'a> {
fn from(arg: &'a Box<ast::Arg>) -> Self {
(&**arg).into()
(arg.as_ref()).into()
}
}
@ -685,13 +685,13 @@ pub enum ComparableExpr<'a> {
impl<'a> From<&'a Box<ast::Expr>> for Box<ComparableExpr<'a>> {
fn from(expr: &'a Box<ast::Expr>) -> Self {
Box::new((&**expr).into())
Box::new((expr.as_ref()).into())
}
}
impl<'a> From<&'a Box<ast::Expr>> for ComparableExpr<'a> {
fn from(expr: &'a Box<ast::Expr>) -> Self {
(&**expr).into()
(expr.as_ref()).into()
}
}
@ -737,7 +737,7 @@ impl<'a> From<&'a ast::Expr> for ComparableExpr<'a> {
body,
range: _range,
}) => Self::Lambda(ExprLambda {
args: (&**args).into(),
args: (args.as_ref()).into(),
body: body.into(),
}),
ast::Expr::IfExp(ast::ExprIfExp {