Fix a number of formatter errors from the cpython repository (#5089)

## Summary

This fixes a number of problems in the formatter that showed up with
various files in the [cpython](https://github.com/python/cpython)
repository. These problems surfaced as unstable formatting and invalid
code. This is not the entirety of problems discovered through cpython,
but a big enough chunk to separate it. Individual fixes are generally
individual commits. They were discovered with #5055, which i update as i
work through the output

## Test Plan

I added regression tests with links to cpython for each entry, except
for the two stubs that also got comment stubs since they'll be
implemented properly later.

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__fmtonoff_py.snap

@@ -222,7 +222,7 @@ d={'a':1,
  # Comment 1
  
  # Comment 2
-@@ -18,109 +16,111 @@
+@@ -18,109 +16,112 @@
  
  # fmt: off
  def func_no_args():
@@ -269,6 +269,7 @@ d={'a':1,
 +    number: int,
 +    no_annotation=None,
 +    text: str = "NOT_YET_IMPLEMENTED_STRING",
++    *,
 +    debug: bool = False,
 +    **kwargs,
 +) -> str:
@@ -393,7 +394,7 @@ d={'a':1,
      # fmt: off
  
      # hey, that won't work
-@@ -130,13 +130,15 @@
+@@ -130,13 +131,15 @@
  
  
  def on_and_off_broken():
@@ -414,7 +415,7 @@ d={'a':1,
      # fmt: on
      # fmt: off
      # ...but comments still get reformatted even though they should not be
-@@ -145,80 +147,21 @@
+@@ -145,80 +148,21 @@
  
  def long_lines():
      if True:
@@ -426,13 +427,11 @@ d={'a':1,
 -                implicit_default=True,
 -            )
 -        )
-+        NOT_IMPLEMENTED_call()
-         # fmt: off
+-        # fmt: off
 -        a = (
 -            unnecessary_bracket()
 -        )
-+        a = NOT_IMPLEMENTED_call()
-         # fmt: on
+-        # fmt: on
 -    _type_comment_re = re.compile(
 -        r"""
 -        ^
@@ -453,9 +452,11 @@ d={'a':1,
 -        )
 -        $
 -        """,
--        # fmt: off
++        NOT_IMPLEMENTED_call()
+         # fmt: off
 -        re.MULTILINE|re.VERBOSE
--        # fmt: on
++        a = NOT_IMPLEMENTED_call()
+         # fmt: on
 -    )
 +    _type_comment_re = NOT_IMPLEMENTED_call()
  
@@ -550,6 +551,7 @@ def function_signature_stress_test(
     number: int,
     no_annotation=None,
     text: str = "NOT_YET_IMPLEMENTED_STRING",
+    *,
     debug: bool = False,
     **kwargs,
 ) -> str:

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__function_py.snap

@@ -126,7 +126,7 @@ def __await__(): return (yield)
  
  
  def func_no_args():
-@@ -14,135 +13,86 @@
+@@ -14,135 +13,87 @@
      b
      c
      if True:
@@ -161,8 +161,8 @@ def __await__(): return (yield)
      number: int,
      no_annotation=None,
 -    text: str = "default",
--    *,
 +    text: str = "NOT_YET_IMPLEMENTED_STRING",
+     *,
      debug: bool = False,
      **kwargs,
  ) -> str:
@@ -339,6 +339,7 @@ def function_signature_stress_test(
     number: int,
     no_annotation=None,
     text: str = "NOT_YET_IMPLEMENTED_STRING",
+    *,
     debug: bool = False,
     **kwargs,
 ) -> str:

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__ruff_test__expression__list_py.snap

@@ -0,0 +1,35 @@
+---
+source: crates/ruff_python_formatter/src/lib.rs
+expression: snapshot
+---
+## Input
+```py
+# Dangling comment placement in empty lists
+# Regression test for https://github.com/python/cpython/blob/03160630319ca26dcbbad65225da4248e54c45ec/Tools/c-analyzer/c_analyzer/datafiles.py#L14-L16
+a1 = [  # a
+]
+a2 = [  # a
+    # b
+]
+a3 = [
+    # b
+]
+```
+
+
+
+## Output
+```py
+# Dangling comment placement in empty lists
+# Regression test for https://github.com/python/cpython/blob/03160630319ca26dcbbad65225da4248e54c45ec/Tools/c-analyzer/c_analyzer/datafiles.py#L14-L16
+a1 = [  # a
+]
+a2 = [  # a
+    # b
+]
+a3 = [
+    # b
+]
+```
+
+

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__ruff_test__statement__function_py.snap

@@ -74,6 +74,28 @@ def test(): ...
 
 # Comment
 def with_leading_comment(): ...
+
+# Comment that could be mistaken for a trailing comment of the function declaration when
+# looking from the position of the if
+# Regression test for https://github.com/python/cpython/blob/ad56340b665c5d8ac1f318964f71697bba41acb7/Lib/logging/__init__.py#L253-L260
+if True:
+    def f1():
+        pass  # a
+else:
+    pass
+
+# Here it's actually a trailing comment
+if True:
+    def f2():
+        pass
+        # a
+else:
+    pass
+
+# Make sure the star is printed
+# Regression test for https://github.com/python/cpython/blob/7199584ac8632eab57612f595a7162ab8d2ebbc0/Lib/warnings.py#L513
+def f(arg1=1, *, kwonlyarg1, kwonlyarg2=2):
+    pass
 ```
 
 
@@ -177,6 +199,30 @@ def test():
 # Comment
 def with_leading_comment():
     ...
+
+
+# Comment that could be mistaken for a trailing comment of the function declaration when
+# looking from the position of the if
+# Regression test for https://github.com/python/cpython/blob/ad56340b665c5d8ac1f318964f71697bba41acb7/Lib/logging/__init__.py#L253-L260
+if True:
+    def f1():
+        pass  # a
+else:
+    pass
+
+# Here it's actually a trailing comment
+if True:
+    def f2():
+        pass
+    # a
+else:
+    pass
+
+
+# Make sure the star is printed
+# Regression test for https://github.com/python/cpython/blob/7199584ac8632eab57612f595a7162ab8d2ebbc0/Lib/warnings.py#L513
+def f(arg1=1, *, kwonlyarg1, kwonlyarg2=2):
+    pass
 ```
 
 

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__trivia__tests__tokenize_comma.snap

@@ -1,6 +1,6 @@
 ---
 source: crates/ruff_python_formatter/src/trivia.rs
-expression: tokens
+expression: test_case.tokens()
 ---
 [
     Token {

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__trivia__tests__tokenize_continuation.snap

@@ -1,6 +1,6 @@
 ---
 source: crates/ruff_python_formatter/src/trivia.rs
-expression: tokens
+expression: test_case.tokens()
 ---
 [
     Token {

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__trivia__tests__tokenize_parentheses.snap

@@ -1,6 +1,6 @@
 ---
 source: crates/ruff_python_formatter/src/trivia.rs
-expression: tokens
+expression: test_case.tokens()
 ---
 [
     Token {

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__trivia__tests__tokenize_substring.snap

@@ -1,6 +1,6 @@
 ---
 source: crates/ruff_python_formatter/src/trivia.rs
-expression: tokens
+expression: test_case.tokens()
 ---
 [
     Token {

crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__trivia__tests__tokenize_trivia.snap

@@ -1,6 +1,6 @@
 ---
 source: crates/ruff_python_formatter/src/trivia.rs
-expression: tokens
+expression: test_case.tokens()
 ---
 [
     Token {