language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 02:39:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] simplify "removing" in UnionBuilder::add (#16947)

Browse source 
## Summary

Simplify "removing" in UnionBuilder::add
It's now O(m) instead of O(n + m) and easier to read.

## Test Plan

cargo test (incl. mdtest)
This commit is contained in:
Aleksei Latyshev 2025-03-24 19:04:03 +01:00 • committed by GitHub
parent e87fee4b3b
commit 68ea2b8b5b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

25
crates/red_knot_python_semantic/src/types/builder.rs
View file

@ -110,25 +110,14 @@ impl<'db> UnionBuilder<'db> {
return self.collapse_to_object();
}
}
match to_remove[..] {
[] => self.elements.push(to_add),
[index] => self.elements[index] = to_add,
_ => {
let mut current_index = 0;
let mut to_remove = to_remove.into_iter();
let mut next_to_remove_index = to_remove.next();
self.elements.retain(|_| {
let retain = if Some(current_index) == next_to_remove_index {
next_to_remove_index = to_remove.next();
false
} else {
true
};
current_index += 1;
retain
});
self.elements.push(to_add);
if let Some((&first, rest)) = to_remove.split_first() {
self.elements[first] = to_add;
// We iterate in descending order to keep remaining indices valid after `swap_remove`.
for &index in rest.iter().rev() {
self.elements.swap_remove(index);
}
} else {
self.elements.push(to_add);
}
}
}