language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-28 04:45:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[ty] Allow unions including Any/Unknown as bases (#18094)

Browse source 
## Summary

Alternative fix for https://github.com/astral-sh/ty/issues/312

## Test Plan

New Markdown test
This commit is contained in:
David Peter 2025-05-16 06:57:26 +02:00 • committed by GitHub
parent 7dc4fefb47
commit 6e39250015
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 82 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

27
crates/ty_python_semantic/src/types/class_base.rs
View file

@ -123,7 +123,32 @@ impl<'db> ClassBase<'db> {
Some(valid_element)
}
}
Type::Union(_) => None, // TODO -- forces consideration of multiple possible MROs?
Type::Union(union) => {
// We do not support full unions of MROs (yet). Until we do,
// support the cases where one of the types in the union is
// a dynamic type such as `Any` or `Unknown`, and all other
// types *would be* valid class bases. In this case, we can
// "fold" the other potential bases into the dynamic type,
// and return `Any`/`Unknown` as the class base to prevent
// invalid-base diagnostics and further downstream errors.
let Some(Type::Dynamic(dynamic)) = union
.elements(db)
.iter()
.find(|elem| matches!(elem, Type::Dynamic(_)))
else {
return None;
};
if union
.elements(db)
.iter()
.all(|elem| ClassBase::try_from_type(db, *elem).is_some())
{
Some(ClassBase::Dynamic(*dynamic))
} else {
None
}
}
Type::NominalInstance(_) => None, // TODO -- handle `__mro_entries__`?
Type::PropertyInstance(_) => None,
Type::Never