language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-27 12:29:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[airflow] apply Replacement::AutoImport to AIR312 (#17570)

Browse source 
## Summary

<!-- What's the purpose of the change? What does it do, and why? -->

This is not yet fixing anything as the names are not changed, but it
lays down the foundation for fixing.

## Test Plan

<!-- How was it tested? -->

the existing test fixture should already cover this change
This commit is contained in:
Wei Lee 2025-05-01 03:53:10 +08:00 • committed by GitHub
parent c5e41c278c
commit 6e765b4527
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 55 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

77
crates/ruff_linter/src/rules/airflow/rules/suggested_to_move_to_provider_in_3.rs
View file

@ -1,5 +1,7 @@
use crate::importer::ImportRequest;
use crate::rules::airflow::helpers::ProviderReplacement; use crate::rules::airflow::helpers::ProviderReplacement;
use ruff_diagnostics::{Diagnostic, Violation}; use ruff_diagnostics::{Diagnostic, Edit, Fix, FixAvailability, Violation};
use ruff_macros::{derive_message_formats, ViolationMetadata}; use ruff_macros::{derive_message_formats, ViolationMetadata};
use ruff_python_ast::{Expr, ExprAttribute}; use ruff_python_ast::{Expr, ExprAttribute};
use ruff_python_semantic::Modules; use ruff_python_semantic::Modules;
@ -34,6 +36,7 @@ pub(crate) struct Airflow3SuggestedToMoveToProvider {
} }
impl Violation for Airflow3SuggestedToMoveToProvider { impl Violation for Airflow3SuggestedToMoveToProvider {
const FIX_AVAILABILITY: FixAvailability = FixAvailability::Sometimes;
#[derive_message_formats] #[derive_message_formats]
fn message(&self) -> String { fn message(&self) -> String {
let Airflow3SuggestedToMoveToProvider { let Airflow3SuggestedToMoveToProvider {
@ -124,14 +127,16 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
let replacement = match qualified_name.segments() { let replacement = match qualified_name.segments() {
// apache-airflow-providers-standard // apache-airflow-providers-standard
["airflow", "hooks", "filesystem", "FSHook"] => ProviderReplacement::ProviderName { ["airflow", "hooks", "filesystem", "FSHook"] => ProviderReplacement::AutoImport {
name: "airflow.providers.standard.hooks.filesystem.FSHook", module: "airflow.providers.standard.hooks.filesystem",
name: "FSHook",
provider: "standard", provider: "standard",
version: "0.0.1", version: "0.0.1",
}, },
["airflow", "hooks", "package_index", "PackageIndexHook"] => { ["airflow", "hooks", "package_index", "PackageIndexHook"] => {
ProviderReplacement::ProviderName { ProviderReplacement::AutoImport {
name: "airflow.providers.standard.hooks.package_index.PackageIndexHook", module: "airflow.providers.standard.hooks.package_index",
name: "PackageIndexHook",
provider: "standard", provider: "standard",
version: "0.0.1", version: "0.0.1",
} }
@ -144,8 +149,9 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
version: "0.0.3", version: "0.0.3",
} }
} }
["airflow", "operators", "bash", "BashOperator"] => ProviderReplacement::ProviderName { ["airflow", "operators", "bash", "BashOperator"] => ProviderReplacement::AutoImport {
name: "airflow.providers.standard.operators.bash.BashOperator", module: "airflow.providers.standard.operators.bash",
name: "BashOperator",
provider: "standard", provider: "standard",
version: "0.0.1", version: "0.0.1",
}, },
@ -165,14 +171,16 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
version: "0.0.2", version: "0.0.2",
} }
} }
["airflow", "operators", "empty", "EmptyOperator"] => ProviderReplacement::ProviderName { ["airflow", "operators", "empty", "EmptyOperator"] => ProviderReplacement::AutoImport {
name: "airflow.providers.standard.operators.empty.EmptyOperator", module: "airflow.providers.standard.operators.empty",
name: "EmptyOperator",
provider: "standard", provider: "standard",
version: "0.0.2", version: "0.0.2",
}, },
["airflow", "operators", "latest_only", "LatestOnlyOperator"] => { ["airflow", "operators", "latest_only", "LatestOnlyOperator"] => {
ProviderReplacement::ProviderName { ProviderReplacement::AutoImport {
name: "airflow.providers.standard.operators.latest_only.LatestOnlyOperator", module: "airflow.providers.standard.operators.latest_only",
name: "LatestOnlyOperator",
provider: "standard", provider: "standard",
version: "0.0.3", version: "0.0.3",
} }
@ -187,8 +195,9 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
version: "0.0.1", version: "0.0.1",
}, },
["airflow", "operators", "weekday", "BranchDayOfWeekOperator"] => { ["airflow", "operators", "weekday", "BranchDayOfWeekOperator"] => {
ProviderReplacement::ProviderName { ProviderReplacement::AutoImport {
name: "airflow.providers.standard.operators.weekday.BranchDayOfWeekOperator", module: "airflow.providers.standard.operators.weekday",
name: "BranchDayOfWeekOperator",
provider: "standard", provider: "standard",
version: "0.0.1", version: "0.0.1",
} }
@ -209,8 +218,9 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
version: "0.0.3", version: "0.0.3",
} }
} }
["airflow", "sensors", "filesystem", "FileSensor"] => ProviderReplacement::ProviderName { ["airflow", "sensors", "filesystem", "FileSensor"] => ProviderReplacement::AutoImport {
name: "airflow.providers.standard.sensors.filesystem.FileSensor", module: "airflow.providers.standard.sensors.filesystem",
name: "FileSensor",
provider: "standard", provider: "standard",
version: "0.0.2", version: "0.0.2",
}, },
@ -230,8 +240,9 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
version: "0.0.1", version: "0.0.1",
} }
} }
["airflow", "sensors", "weekday", "DayOfWeekSensor"] => ProviderReplacement::ProviderName { ["airflow", "sensors", "weekday", "DayOfWeekSensor"] => ProviderReplacement::AutoImport {
name: "airflow.providers.standard.sensors.weekday.DayOfWeekSensor", module: "airflow.providers.standard.sensors.weekday",
name: "DayOfWeekSensor",
provider: "standard", provider: "standard",
version: "0.0.1", version: "0.0.1",
}, },
@ -243,8 +254,9 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
version: "0.0.3", version: "0.0.3",
} }
} }
["airflow", "triggers", "file", "FileTrigger"] => ProviderReplacement::ProviderName { ["airflow", "triggers", "file", "FileTrigger"] => ProviderReplacement::AutoImport {
name: "airflow.providers.standard.triggers.file.FileTrigger", module: "airflow.providers.standard.triggers.file",
name: "FileTrigger",
provider: "standard", provider: "standard",
version: "0.0.3", version: "0.0.3",
}, },
@ -258,11 +270,32 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
} }
_ => return, _ => return,
}; };
checker.report_diagnostic(Diagnostic::new(
let mut diagnostic = Diagnostic::new(
Airflow3SuggestedToMoveToProvider { Airflow3SuggestedToMoveToProvider {
deprecated: qualified_name.to_string(), deprecated: qualified_name.to_string(),
replacement, replacement: replacement.clone(),
}, },
ranged.range(), ranged.range(),
)); );
if let ProviderReplacement::AutoImport {
module,
name,
provider: _,
version: _,
} = replacement
{
diagnostic.try_set_fix(|| {
let (import_edit, binding) = checker.importer().get_or_import_symbol(
&ImportRequest::import_from(module, name),
expr.start(),
checker.semantic(),
)?;
let replacement_edit = Edit::range_replacement(binding, ranged.range());
Ok(Fix::safe_edits(import_edit, [replacement_edit]))
});
}
checker.report_diagnostic(diagnostic);
} }