mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-02 06:42:02 +00:00
[red-knot] Add support for untitled files (#12492)
## Summary This PR adds support for untitled files in the Red Knot project. Refer to the [design discussion](https://github.com/astral-sh/ruff/discussions/12336) for more details. ### Changes * The `parsed_module` always assumes that the `SystemVirtual` path is of `PySourceType::Python`. * For the module resolver, as suggested, I went ahead by adding a new `SystemOrVendoredPath` enum and renamed `FilePathRef` to `SystemOrVendoredPathRef` (happy to consider better names here). * The `file_to_module` query would return if it's a `FilePath::SystemVirtual` variant because a virtual file doesn't belong to any module. * The sync implementation for the system virtual path is basically the same as that of system path except that it uses the `virtual_path_metadata`. The reason for this is that the system (language server) would provide the metadata on whether it still exists or not and if it exists, the corresponding metadata. For point (1), VS Code would use `Untitled-1` for Python files and `Untitled-1.ipynb` for Jupyter Notebooks. We could use this distinction to determine whether the source type is `Python` or `Ipynb`. ## Test Plan Added test cases in #12526
This commit is contained in:
parent
71f7aa4971
commit
6f4db8675b
11 changed files with 534 additions and 63 deletions
|
@ -11,6 +11,7 @@ use crate::file_revision::FileRevision;
|
|||
|
||||
pub use self::path::{
|
||||
deduplicate_nested_paths, DeduplicatedNestedPathsIter, SystemPath, SystemPathBuf,
|
||||
SystemVirtualPath, SystemVirtualPathBuf,
|
||||
};
|
||||
|
||||
mod memory_fs;
|
||||
|
@ -50,6 +51,18 @@ pub trait System: Debug {
|
|||
/// representation fall-back to deserializing the notebook from a string.
|
||||
fn read_to_notebook(&self, path: &SystemPath) -> std::result::Result<Notebook, NotebookError>;
|
||||
|
||||
/// Reads the metadata of the virtual file at `path`.
|
||||
fn virtual_path_metadata(&self, path: &SystemVirtualPath) -> Result<Metadata>;
|
||||
|
||||
/// Reads the content of the virtual file at `path` into a [`String`].
|
||||
fn read_virtual_path_to_string(&self, path: &SystemVirtualPath) -> Result<String>;
|
||||
|
||||
/// Reads the content of the virtual file at `path` as a [`Notebook`].
|
||||
fn read_virtual_path_to_notebook(
|
||||
&self,
|
||||
path: &SystemVirtualPath,
|
||||
) -> std::result::Result<Notebook, NotebookError>;
|
||||
|
||||
/// Returns `true` if `path` exists.
|
||||
fn path_exists(&self, path: &SystemPath) -> bool {
|
||||
self.path_metadata(path).is_ok()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue