language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 13:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix TODO directive out of bounds acccess (#13756)

Browse source
This commit is contained in:
Micha Reiser 2024-10-15 10:49:53 +02:00 • committed by GitHub
parent 04b636cba2
commit 72ac6cd5a5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 21 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/ruff_linter/resources/test/fixtures/flake8_fixme/T00.py vendored
View file

@ -6,3 +6,8 @@
# hack: hack # hack: hack
# FIXME: fixme # FIXME: fixme
# fixme: fixme # fixme: fixme
# test # TODO: todo
# #d#

2
crates/ruff_linter/src/directives.rs
View file

@ -316,7 +316,7 @@ impl<'a> TodoDirective<'a> {
// Shrink the subset to check for the next phrase starting with "#". // Shrink the subset to check for the next phrase starting with "#".
if let Some(new_offset) = trimmed.find('#') { if let Some(new_offset) = trimmed.find('#') {
relative_offset += TextSize::try_from(new_offset).unwrap(); relative_offset += TextSize::try_from(new_offset).unwrap();
subset = &subset[relative_offset.to_usize()..]; subset = &comment[relative_offset.to_usize()..];
} else { } else {
break; break;
}; };

10
crates/ruff_linter/src/rules/flake8_fixme/snapshots/ruff_linter__rules__flake8_fixme__tests__line-contains-fixme_T00.py.snap
View file

@ -12,10 +12,10 @@ T00.py:7:3: FIX001 Line contains FIXME, consider resolving the issue
T00.py:8:3: FIX001 Line contains FIXME, consider resolving the issue T00.py:8:3: FIX001 Line contains FIXME, consider resolving the issue
| |
6 | # hack: hack 6 | # hack: hack
7 | # FIXME: fixme 7 | # FIXME: fixme
8 | # fixme: fixme 8 | # fixme: fixme
| ^^^^^ FIX001 | ^^^^^ FIX001
9 |
10 | # test # TODO: todo
| |

8
crates/ruff_linter/src/rules/flake8_fixme/snapshots/ruff_linter__rules__flake8_fixme__tests__line-contains-todo_T00.py.snap
View file

@ -18,4 +18,10 @@ T00.py:2:3: FIX002 Line contains TODO, consider resolving the issue
4 | # xxx: xxx 4 | # xxx: xxx
| |
T00.py:10:10: FIX002 Line contains TODO, consider resolving the issue
|
8 | # fixme: fixme
9 |
10 | # test # TODO: todo
| ^^^^ FIX002
|