[ty] Shrink size of AstNodeRef (#20028)

## Summary

Removes the `module_ptr` field from `AstNodeRef` in release mode, and
change `NodeIndex` to a `NonZeroU32` to reduce the size of
`Option<AstNodeRef<_>>` fields.

I believe CI runs in debug mode, so this won't show up in the memory
report, but this reduces memory by ~2% in release mode.
This commit is contained in:
Ibraheem Ahmed 2025-08-22 17:03:22 -04:00 committed by GitHub
parent 886c4e4773
commit 7abc41727b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
648 changed files with 19641 additions and 20364 deletions

View file

@ -7,20 +7,20 @@ input_file: crates/ruff_python_parser/resources/valid/expressions/attribute.py
```
Module(
ModModule {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..90,
body: [
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..10,
value: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..10,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..5,
id: Name("value"),
ctx: Load,
@ -29,7 +29,7 @@ Module(
attr: Identifier {
id: Name("attr"),
range: 6..10,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},
@ -38,19 +38,19 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 11..23,
value: Call(
ExprCall {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 11..23,
func: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 11..21,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 11..16,
id: Name("value"),
ctx: Load,
@ -59,14 +59,14 @@ Module(
attr: Identifier {
id: Name("attr"),
range: 17..21,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},
),
arguments: Arguments {
range: 21..23,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
args: [],
keywords: [],
},
@ -76,19 +76,19 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 24..36,
value: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 24..36,
value: Call(
ExprCall {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 24..31,
func: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 24..29,
id: Name("value"),
ctx: Load,
@ -96,7 +96,7 @@ Module(
),
arguments: Arguments {
range: 29..31,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
args: [],
keywords: [],
},
@ -105,7 +105,7 @@ Module(
attr: Identifier {
id: Name("attr"),
range: 32..36,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},
@ -114,27 +114,27 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 37..55,
value: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 37..55,
value: Call(
ExprCall {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 37..51,
func: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 37..49,
value: Call(
ExprCall {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 37..44,
func: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 37..42,
id: Name("value"),
ctx: Load,
@ -142,7 +142,7 @@ Module(
),
arguments: Arguments {
range: 42..44,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
args: [],
keywords: [],
},
@ -151,14 +151,14 @@ Module(
attr: Identifier {
id: Name("attr"),
range: 45..49,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},
),
arguments: Arguments {
range: 49..51,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
args: [],
keywords: [],
},
@ -167,7 +167,7 @@ Module(
attr: Identifier {
id: Name("foo"),
range: 52..55,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},
@ -176,19 +176,19 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 56..70,
value: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 56..70,
value: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 56..66,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 56..61,
id: Name("value"),
ctx: Load,
@ -197,7 +197,7 @@ Module(
attr: Identifier {
id: Name("attr"),
range: 62..66,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},
@ -205,7 +205,7 @@ Module(
attr: Identifier {
id: Name("foo"),
range: 67..70,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},
@ -214,23 +214,23 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 71..89,
value: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 71..89,
value: Call(
ExprCall {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 71..85,
func: Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 71..83,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 72..77,
id: Name("value"),
ctx: Load,
@ -239,14 +239,14 @@ Module(
attr: Identifier {
id: Name("attr"),
range: 79..83,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},
),
arguments: Arguments {
range: 83..85,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
args: [],
keywords: [],
},
@ -255,7 +255,7 @@ Module(
attr: Identifier {
id: Name("foo"),
range: 86..89,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Load,
},