language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-21 07:41:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Shrink size of AstNodeRef (#20028)

Browse source 
## Summary

Removes the `module_ptr` field from `AstNodeRef` in release mode, and
change `NodeIndex` to a `NonZeroU32` to reduce the size of
`Option<AstNodeRef<_>>` fields.

I believe CI runs in debug mode, so this won't show up in the memory
report, but this reduces memory by ~2% in release mode.
This commit is contained in:
Ibraheem Ahmed 2025-08-22 17:03:22 -04:00 • committed by GitHub
parent 886c4e4773
commit 7abc41727b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
648 changed files with 19641 additions and 20364 deletions
Download patch file Download diff file Expand all files Collapse all files

190
crates/ruff_python_parser/tests/snapshots/valid_syntax@expressions__compare.py.snap
View file

@ -7,20 +7,20 @@ input_file: crates/ruff_python_parser/resources/valid/expressions/compare.py
```
Module(
ModModule {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..542,
body: [
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 9..15,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 9..15,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 9..10,
id: Name("a"),
ctx: Load,
@ -32,7 +32,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 14..15,
id: Name("b"),
ctx: Load,
@ -45,15 +45,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 16..21,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 16..21,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 16..17,
id: Name("b"),
ctx: Load,
@ -65,7 +65,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 20..21,
id: Name("a"),
ctx: Load,
@ -78,15 +78,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 22..27,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 22..27,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 22..23,
id: Name("b"),
ctx: Load,
@ -98,7 +98,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 26..27,
id: Name("a"),
ctx: Load,
@ -111,15 +111,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 28..34,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 28..34,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 28..29,
id: Name("a"),
ctx: Load,
@ -131,7 +131,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 33..34,
id: Name("b"),
ctx: Load,
@ -144,15 +144,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 35..41,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 35..41,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 35..36,
id: Name("a"),
ctx: Load,
@ -164,7 +164,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 40..41,
id: Name("b"),
ctx: Load,
@ -177,15 +177,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 42..48,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 42..48,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 42..43,
id: Name("a"),
ctx: Load,
@ -197,7 +197,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 47..48,
id: Name("b"),
ctx: Load,
@ -210,15 +210,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 49..55,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 49..55,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 49..50,
id: Name("a"),
ctx: Load,
@ -230,7 +230,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 54..55,
id: Name("c"),
ctx: Load,
@ -243,15 +243,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 56..62,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 56..62,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 56..57,
id: Name("a"),
ctx: Load,
@ -263,7 +263,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 61..62,
id: Name("b"),
ctx: Load,
@ -276,15 +276,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 63..73,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 63..73,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 63..64,
id: Name("a"),
ctx: Load,
@ -296,7 +296,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 72..73,
id: Name("c"),
ctx: Load,
@ -309,15 +309,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 74..84,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 74..84,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 74..75,
id: Name("a"),
ctx: Load,
@ -329,7 +329,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 83..84,
id: Name("b"),
ctx: Load,
@ -342,15 +342,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 110..156,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 110..156,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 110..111,
id: Name("a"),
ctx: Load,
@ -366,7 +366,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 119..120,
id: Name("b"),
ctx: Load,
@ -374,7 +374,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 128..129,
id: Name("c"),
ctx: Load,
@ -382,7 +382,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 137..138,
id: Name("d"),
ctx: Load,
@ -390,7 +390,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 146..147,
id: Name("e"),
ctx: Load,
@ -398,7 +398,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 155..156,
id: Name("f"),
ctx: Load,
@ -411,19 +411,19 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 177..203,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 177..203,
left: BinOp(
ExprBinOp {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 177..182,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 177..178,
id: Name("a"),
ctx: Load,
@ -432,7 +432,7 @@ Module(
op: BitOr,
right: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 181..182,
id: Name("b"),
ctx: Load,
@ -447,11 +447,11 @@ Module(
comparators: [
BinOp(
ExprBinOp {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 185..190,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 185..186,
id: Name("c"),
ctx: Load,
@ -460,7 +460,7 @@ Module(
op: BitOr,
right: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 189..190,
id: Name("d"),
ctx: Load,
@ -470,11 +470,11 @@ Module(
),
BinOp(
ExprBinOp {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 198..203,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 198..199,
id: Name("e"),
ctx: Load,
@ -483,7 +483,7 @@ Module(
op: BitAnd,
right: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 202..203,
id: Name("f"),
ctx: Load,
@ -498,20 +498,20 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 379..393,
value: UnaryOp(
ExprUnaryOp {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 379..393,
op: Not,
operand: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 383..393,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 383..384,
id: Name("x"),
ctx: Load,
@ -523,7 +523,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 392..393,
id: Name("y"),
ctx: Load,
@ -538,17 +538,17 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 395..416,
value: BoolOp(
ExprBoolOp {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 395..416,
op: Or,
values: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 395..396,
id: Name("x"),
ctx: Load,
@ -556,17 +556,17 @@ Module(
),
BoolOp(
ExprBoolOp {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 400..416,
op: And,
values: [
Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 400..410,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 400..401,
id: Name("y"),
ctx: Load,
@ -578,7 +578,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 409..410,
id: Name("z"),
ctx: Load,
@ -589,7 +589,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 415..416,
id: Name("a"),
ctx: Load,
@ -605,15 +605,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 417..429,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 417..429,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 417..418,
id: Name("x"),
ctx: Load,
@ -625,11 +625,11 @@ Module(
comparators: [
Await(
ExprAwait {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 422..429,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 428..429,
id: Name("y"),
ctx: Load,
@ -644,15 +644,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 430..446,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 430..446,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 430..431,
id: Name("x"),
ctx: Load,
@ -664,11 +664,11 @@ Module(
comparators: [
Await(
ExprAwait {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 439..446,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 445..446,
id: Name("y"),
ctx: Load,
@ -683,15 +683,15 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 489..541,
value: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 489..541,
left: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 489..490,
id: Name("a"),
ctx: Load,
@ -711,7 +711,7 @@ Module(
comparators: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 493..494,
id: Name("b"),
ctx: Load,
@ -719,7 +719,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 498..499,
id: Name("c"),
ctx: Load,
@ -727,7 +727,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 502..503,
id: Name("d"),
ctx: Load,
@ -735,7 +735,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 507..508,
id: Name("e"),
ctx: Load,
@ -743,7 +743,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 516..517,
id: Name("f"),
ctx: Load,
@ -751,7 +751,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 525..526,
id: Name("g"),
ctx: Load,
@ -759,7 +759,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 530..531,
id: Name("h"),
ctx: Load,
@ -767,7 +767,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 535..536,
id: Name("i"),
ctx: Load,
@ -775,7 +775,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 540..541,
id: Name("j"),
ctx: Load,