language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 13:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] Remove duplicate property test (#15450)

Browse source 
## Summary

Follow-up PR from https://github.com/astral-sh/ruff/pull/15415  🥲 

The exact same property test already exists:
`intersection_assignable_to_both` and
`all_type_pairs_can_be_assigned_from_their_intersection`

## Test Plan

`cargo test -p red_knot_python_semantic -- --ignored
types::property_tests::flaky`
This commit is contained in:
cake-monotone 2025-01-13 16:18:41 +09:00 • committed by GitHub
parent 70c3be88b9
commit 82d06a198d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/red_knot_python_semantic/src/types/property_tests.rs
View file

@ -344,13 +344,6 @@ mod flaky {
forall types t. t.is_assignable_to(db, t) forall types t. t.is_assignable_to(db, t)
); );
// Currently fails due to https://github.com/astral-sh/ruff/issues/14899
// An intersection of two types should be assignable to both of them
type_property_test!(
intersection_assignable_to_both, db,
forall types s, t. intersection(db, s, t).is_assignable_to(db, s) && intersection(db, s, t).is_assignable_to(db, t)
);
// `S <: T` and `T <: S` implies that `S` is equivalent to `T`. // `S <: T` and `T <: S` implies that `S` is equivalent to `T`.
// This very often passes now, but occasionally flakes due to https://github.com/astral-sh/ruff/issues/15380 // This very often passes now, but occasionally flakes due to https://github.com/astral-sh/ruff/issues/15380
type_property_test!( type_property_test!(
@ -380,6 +373,7 @@ mod flaky {
// And for non-fully-static types, the intersection of a pair of types // And for non-fully-static types, the intersection of a pair of types
// should be assignable to both types of the pair. // should be assignable to both types of the pair.
// Currently fails due to https://github.com/astral-sh/ruff/issues/14899
type_property_test!( type_property_test!(
all_type_pairs_can_be_assigned_from_their_intersection, db, all_type_pairs_can_be_assigned_from_their_intersection, db,
forall types s, t. intersection(db, s, t).is_assignable_to(db, s) && intersection(db, s, t).is_assignable_to(db, t) forall types s, t. intersection(db, s, t).is_assignable_to(db, s) && intersection(db, s, t).is_assignable_to(db, t)