language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-27 04:19:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Migrate flake8_bugbear rules to unspecified to suggested (#4616)

Browse source
This commit is contained in:
Sladyn 2023-05-24 09:16:33 -07:00 • committed by GitHub
parent dcd2bfaab7
commit 8c9215489e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ruff/src/rules/flake8_bugbear/rules/getattr_with_constant.rs
View file

@ -64,10 +64,8 @@ pub(crate) fn getattr_with_constant(
}
let mut diagnostic = Diagnostic::new(GetAttrWithConstant, expr.range());
if checker.patch(diagnostic.kind.rule()) {
#[allow(deprecated)]
diagnostic.set_fix(Fix::unspecified(Edit::range_replacement(
diagnostic.set_fix(Fix::suggested(Edit::range_replacement(
checker.generator().expr(&attribute(obj, value)),
expr.range(),
)));

4
crates/ruff/src/rules/flake8_bugbear/rules/setattr_with_constant.rs
View file

@ -79,10 +79,8 @@ pub(crate) fn setattr_with_constant(
{
if expr == child.as_ref() {
let mut diagnostic = Diagnostic::new(SetAttrWithConstant, expr.range());
if checker.patch(diagnostic.kind.rule()) {
#[allow(deprecated)]
diagnostic.set_fix(Fix::unspecified(Edit::range_replacement(
diagnostic.set_fix(Fix::suggested(Edit::range_replacement(
assignment(obj, name, value, checker.generator()),
expr.range(),
)));

3
crates/ruff/src/rules/flake8_bugbear/rules/unused_loop_control_variable.rs
View file

@ -160,8 +160,7 @@ pub(crate) fn unused_loop_control_variable(checker: &mut Checker, target: &Expr,
.map(|binding_id| &checker.semantic_model().bindings[binding_id])
.all(|binding| !binding.is_used())
{
#[allow(deprecated)]
diagnostic.set_fix(Fix::unspecified(Edit::range_replacement(
diagnostic.set_fix(Fix::suggested(Edit::range_replacement(
rename,
expr.range(),
)));