language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-29 13:25:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Migrate some inference tests to mdtests (#14795)

Browse source 
As part of #13696, this PR ports a smallish number of inference tests
over to the mdtest framework.
This commit is contained in:
Douglas Creager 2024-12-06 05:19:22 -05:00 • committed by GitHub
parent b01a651e69
commit 918358aaa6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 139 additions and 248 deletions
Download patch file Download diff file Expand all files Collapse all files

199
crates/red_knot_python_semantic/src/types/infer.rs
View file

@ -5123,16 +5123,6 @@ mod tests {
assert_diagnostic_messages(diagnostics, expected);
}
#[test]
fn from_import_with_no_module_name() -> anyhow::Result<()> {
// This test checks that invalid syntax in a `StmtImportFrom` node
// leads to the type being inferred as `Unknown`
let mut db = setup_db();
db.write_file("src/foo.py", "from import bar")?;
assert_public_ty(&db, "src/foo.py", "bar", "Unknown");
Ok(())
}
#[test]
fn resolve_method() -> anyhow::Result<()> {
let mut db = setup_db();
@ -5282,112 +5272,6 @@ mod tests {
Ok(())
}
#[test]
fn bytes_type() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"src/a.py",
"
w = b'red' b'knot'
x = b'hello'
y = b'world' + b'!'
z = b'\\xff\\x00'
",
)?;
assert_public_ty(&db, "src/a.py", "w", "Literal[b\"redknot\"]");
assert_public_ty(&db, "src/a.py", "x", "Literal[b\"hello\"]");
assert_public_ty(&db, "src/a.py", "y", "Literal[b\"world!\"]");
assert_public_ty(&db, "src/a.py", "z", "Literal[b\"\\xff\\x00\"]");
Ok(())
}
#[test]
fn ellipsis_type() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"src/a.py",
"
x = ...
",
)?;
// TODO: sys.version_info
assert_public_ty(&db, "src/a.py", "x", "EllipsisType | ellipsis");
Ok(())
}
#[test]
fn import_cycle() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"src/a.py",
"
class A: pass
import b
class C(b.B): pass
",
)?;
db.write_dedented(
"src/b.py",
"
from a import A
class B(A): pass
",
)?;
let a = system_path_to_file(&db, "src/a.py").expect("file to exist");
let c_ty = global_symbol(&db, a, "C").expect_type();
let c_class = c_ty.expect_class_literal().class;
let mut c_mro = c_class.iter_mro(&db);
let b_ty = c_mro.nth(1).unwrap();
let b_class = b_ty.expect_class_base();
assert_eq!(b_class.name(&db), "B");
let mut b_mro = b_class.iter_mro(&db);
let a_ty = b_mro.nth(1).unwrap();
let a_class = a_ty.expect_class_base();
assert_eq!(a_class.name(&db), "A");
Ok(())
}
/// An unbound function local that has definitions in the scope does not fall back to globals.
#[test]
fn unbound_function_local() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"src/a.py",
"
x = 1
def f():
y = x
x = 2
",
)?;
let file = system_path_to_file(&db, "src/a.py").expect("file to exist");
let index = semantic_index(&db, file);
let function_scope = index
.child_scopes(FileScopeId::global())
.next()
.unwrap()
.0
.to_scope_id(&db, file);
let y_ty = symbol(&db, function_scope, "y").expect_type();
let x_ty = symbol(&db, function_scope, "x").expect_type();
assert_eq!(y_ty.display(&db).to_string(), "Unknown");
assert_eq!(x_ty.display(&db).to_string(), "Literal[2]");
Ok(())
}
/// A name reference to a never-defined symbol in a function is implicitly a global lookup.
#[test]
fn implicit_global_in_function() -> anyhow::Result<()> {
@ -5562,89 +5446,6 @@ mod tests {
Ok(())
}
#[test]
fn nonlocal_name_reference() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"/src/a.py",
"
def f():
x = 1
def g():
y = x
",
)?;
assert_scope_ty(&db, "/src/a.py", &["f", "g"], "y", "Literal[1]");
Ok(())
}
#[test]
fn nonlocal_name_reference_multi_level() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"/src/a.py",
"
def f():
x = 1
def g():
def h():
y = x
",
)?;
assert_scope_ty(&db, "/src/a.py", &["f", "g", "h"], "y", "Literal[1]");
Ok(())
}
#[test]
fn nonlocal_name_reference_skips_class_scope() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"/src/a.py",
"
def f():
x = 1
class C:
x = 2
def g():
y = x
",
)?;
assert_scope_ty(&db, "/src/a.py", &["f", "C", "g"], "y", "Literal[1]");
Ok(())
}
#[test]
fn nonlocal_name_reference_skips_annotation_only_assignment() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"/src/a.py",
"
def f():
x = 1
def g():
// it's pretty weird to have an annotated assignment in a function where the
// name is otherwise not defined; maybe should be an error?
x: int
def h():
y = x
",
)?;
assert_scope_ty(&db, "/src/a.py", &["f", "g", "h"], "y", "Literal[1]");
Ok(())
}
#[test]
fn basic_comprehension() -> anyhow::Result<()> {
let mut db = setup_db();

9
crates/red_knot_python_semantic/src/types/mro.rs
View file

@ -328,15 +328,6 @@ impl<'db> ClassBase<'db> {
Display { base: self, db }
}
#[cfg(test)]
#[track_caller]
pub(super) fn expect_class_base(self) -> Class<'db> {
match self {
ClassBase::Class(class) => class,
_ => panic!("Expected a `ClassBase::Class()` variant"),
}
}
/// Return a `ClassBase` representing the class `builtins.object`
fn object(db: &'db dyn Db) -> Self {
KnownClass::Object