language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-07-16 09:35:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix trailing kwargs end of line comment after slash (#10297)

Browse source 
## Summary

Fixes the handling end of line comments that belong to `**kwargs` when
the `**kwargs` come after a slash.

The issue was that we missed to include the `**kwargs` start position
when determining the start of the next node coming after the `/`.

Fixes https://github.com/astral-sh/ruff/issues/10281

## Test Plan

Added test
This commit is contained in:
Micha Reiser 2024-03-08 15:45:26 +01:00 • committed by GitHub
parent c504d7ab11
commit 965adbed4b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff_python_formatter/src/other/parameters.rs
View file

@ -450,6 +450,7 @@ pub(crate) fn find_parameter_separators(
// * `f(a, /, b)`
// * `f(a, /, *b)`
// * `f(a, /, *, b)`
// * `f(a, /, *, **b)`
// * `f(a, /)`
let slash_following_start = parameters
.args
@ -457,6 +458,7 @@ pub(crate) fn find_parameter_separators(
.map(Ranged::start)
.or(parameters.vararg.as_ref().map(|first| first.start()))
.or(star.as_ref().map(|star| star.separator.start()))
.or(parameters.kwarg.as_deref().map(Ranged::start))
.unwrap_or(parameters.end());
let slash = slash.map(|(preceding_end, slash)| ParameterSeparator {
preceding_end,