language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-27 04:19:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Revert change to require_git(false) in WalkBuilder (#6368)

Browse source 
## Summary

This was changed to fix https://github.com/astral-sh/ruff/issues/5930
(respect `.gitignore` for unzipped source repositories), but led to
undesirable behavior whereby `.gitignore` files in parent directories
are respected regardless of whether you're working in a child git
repository (see: https://github.com/astral-sh/ruff/issues/6335). The
latter is a bigger problem than the former is an important use-case to
support, so pragmatically erring on the side of a revert.

Closes https://github.com/astral-sh/ruff/issues/6335.
This commit is contained in:
Charlie Marsh 2023-08-05 15:45:50 -04:00 • committed by GitHub
parent be657f5e7e
commit a5a29bb8d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/ruff/src/resolver.rs
View file

@ -262,7 +262,6 @@ pub fn python_files_in_path(
builder.add(path); builder.add(path);
} }
builder.standard_filters(pyproject_config.settings.lib.respect_gitignore); builder.standard_filters(pyproject_config.settings.lib.respect_gitignore);
builder.require_git(false);
builder.hidden(false); builder.hidden(false);
let walker = builder.build_parallel(); let walker = builder.build_parallel();