language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-03 15:15:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove allocation from ruff_python_stdlib::builtins::python_builtins (#13317)

Browse source
This commit is contained in:
Alex Waygood 2024-09-10 16:34:24 -04:00 • committed by GitHub
parent 2ca78721e6
commit acab1f4fd8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 45 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

25
crates/ruff_linter/src/checkers/ast/mod.rs
View file

@ -1951,20 +1951,25 @@ impl<'a> Checker<'a> {
}
fn bind_builtins(&mut self) {
let standard_builtins = python_builtins(
self.settings.target_version.minor(),
self.source_type.is_ipynb(),
);
for builtin in standard_builtins
.iter()
.chain(MAGIC_GLOBALS.iter())
.copied()
.chain(self.settings.builtins.iter().map(String::as_str))
{
let mut bind_builtin = |builtin| {
// Add the builtin to the scope.
let binding_id = self.semantic.push_builtin();
let scope = self.semantic.global_scope_mut();
scope.add(builtin, binding_id);
};
let standard_builtins = python_builtins(
self.settings.target_version.minor(),
self.source_type.is_ipynb(),
);
for builtin in standard_builtins {
bind_builtin(builtin);
}
for builtin in MAGIC_GLOBALS {
bind_builtin(builtin);
}
for builtin in &self.settings.builtins {
bind_builtin(builtin);
}
}