language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 13:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] better docs for use-def maps (#12357)

Browse source 
Add better doc comments and comments, as well as one debug assertion, to
use-def map building.
This commit is contained in:
Carl Meyer 2024-07-17 17:50:58 -07:00 • committed by GitHub
parent 985a999234
commit b2a49d8140
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 231 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

20
crates/red_knot_python_semantic/src/semantic_index/builder.rs
View file

@ -139,11 +139,11 @@ impl<'db> SemanticIndexBuilder<'db> {
self.current_use_def_map().snapshot()
}
fn flow_set(&mut self, state: &FlowSnapshot) {
self.current_use_def_map().set(state);
fn flow_restore(&mut self, state: FlowSnapshot) {
self.current_use_def_map().restore(state);
}
fn flow_merge(&mut self, state: &FlowSnapshot) {
fn flow_merge(&mut self, state: FlowSnapshot) {
self.current_use_def_map().merge(state);
}
@ -397,20 +397,20 @@ where
let mut post_clauses: Vec<FlowSnapshot> = vec![self.flow_snapshot()];
for clause in &node.elif_else_clauses {
// we can only take an elif/else clause if none of the previous ones were taken
self.flow_set(&pre_if);
self.flow_restore(pre_if.clone());
self.visit_elif_else_clause(clause);
post_clauses.push(self.flow_snapshot());
if clause.test.is_none() {
last_clause_is_else = true;
}
}
let mut post_clause_iter = post_clauses.iter();
let mut post_clause_iter = post_clauses.into_iter();
if last_clause_is_else {
// if the last clause was an else, the pre_if state can't directly reach the
// post-state; we have to enter one of the clauses.
self.flow_set(post_clause_iter.next().unwrap());
// post-state; we must enter one of the clauses.
self.flow_restore(post_clause_iter.next().unwrap());
} else {
self.flow_set(&pre_if);
self.flow_restore(pre_if);
}
for post_clause_state in post_clause_iter {
self.flow_merge(post_clause_state);
@ -483,9 +483,9 @@ where
let pre_if = self.flow_snapshot();
self.visit_expr(body);
let post_body = self.flow_snapshot();
self.flow_set(&pre_if);
self.flow_restore(pre_if);
self.visit_expr(orelse);
self.flow_merge(&post_body);
self.flow_merge(post_body);
}
_ => {
walk_expr(self, expr);