language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-08 04:38:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Consider logger candidate from logging module only (#3878)

Browse source
This commit is contained in:
Dhruv Manilawala 2023-04-05 01:22:57 +05:30 • committed by GitHub
parent 390d7dcf39
commit b6155232ac
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/ruff_python_semantic/src/analyze/logging.rs
View file

@ -18,9 +18,15 @@ use crate::context::Context;
/// ```
pub fn is_logger_candidate(context: &Context, func: &Expr) -> bool {
if let ExprKind::Attribute { value, .. } = &func.node {
let Some(call_path) = context
.resolve_call_path(value)
.or_else(|| collect_call_path(value)) else {
let Some(call_path) = (if let Some(call_path) = context.resolve_call_path(value) {
if call_path.first().map_or(false, |module| *module == "logging") {
Some(call_path)
} else {
None
}
} else {
collect_call_path(value)
}) else {
return false;
};
if let Some(tail) = call_path.last() {