language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-28 12:55:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Change --fix-only exit semantics to mirror --fix (#4146)

Browse source
This commit is contained in:
Charlie Marsh 2023-05-04 12:03:15 -07:00 • committed by GitHub
parent 717128112d
commit b71cc3789f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
BREAKING_CHANGES.md
View file

@ -1,5 +1,16 @@
# Breaking Changes # Breaking Changes
## 0.0.265
### `--fix-only` now exits with a zero exit code, unless `--exit-non-zero-on-fix` is specified ([#4146](https://github.com/charliermarsh/ruff/pull/4146))
Previously, `--fix-only` would exit with a non-zero exit code if any fixes were applied. This
behavior was inconsistent with `--fix`, and further, meant that `--exit-non-zero-on-fix` was
effectively ignored when `--fix-only` was specified.
Now, `--fix-only` will exit with a zero exit code, unless `--exit-non-zero-on-fix` is specified,
in which case it will exit with a non-zero exit code if any fixes were applied.
## 0.0.260 ## 0.0.260
### Fixes are now represented as a list of edits ([#3709](https://github.com/charliermarsh/ruff/pull/3709)) ### Fixes are now represented as a list of edits ([#3709](https://github.com/charliermarsh/ruff/pull/3709))

20
crates/ruff_cli/src/lib.rs
View file

@ -278,11 +278,26 @@ fn check(args: CheckArgs, log_level: LogLevel) -> Result<ExitStatus> {
} }
if !cli.exit_zero { if !cli.exit_zero {
if cli.diff || fix_only { if cli.diff {
// If we're printing a diff, we always want to exit non-zero if there are
// any fixable violations (since we've printed the diff, but not applied the
// fixes).
if !diagnostics.fixed.is_empty() { if !diagnostics.fixed.is_empty() {
return Ok(ExitStatus::Failure); return Ok(ExitStatus::Failure);
} }
} else if cli.exit_non_zero_on_fix { } else if fix_only {
// If we're only fixing, we want to exit zero (since we've fixed all fixable
// violations), unless we're explicitly asked to exit non-zero on fix.
if cli.exit_non_zero_on_fix {
if !diagnostics.fixed.is_empty() {
return Ok(ExitStatus::Failure);
}
}
} else {
// If we're running the linter (not just fixing), we want to exit non-zero if
// there are any violations, unless we're explicitly asked to exit zero on
// fix.
if cli.exit_non_zero_on_fix {
if !diagnostics.fixed.is_empty() || !diagnostics.messages.is_empty() { if !diagnostics.fixed.is_empty() || !diagnostics.messages.is_empty() {
return Ok(ExitStatus::Failure); return Ok(ExitStatus::Failure);
} }
@ -293,5 +308,6 @@ fn check(args: CheckArgs, log_level: LogLevel) -> Result<ExitStatus> {
} }
} }
} }
}
Ok(ExitStatus::Success) Ok(ExitStatus::Success)
} }