language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-27 12:29:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix SIM113 false positive with async for loops (#9996)

Browse source 
## Summary
Ignore `async for` loops when checking the SIM113 rule.

Closes #9995 

## Test Plan
A new test case was added to SIM113.py with an async for loop.
This commit is contained in:
Adrien Ball 2024-02-16 04:40:01 +01:00 • committed by GitHub
parent fe79798c12
commit c3bba54b6b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM113.py vendored
View file

@ -193,3 +193,11 @@ def func():
for y in range(5): for y in range(5):
g(x, idx) g(x, idx)
idx += 1 idx += 1
async def func():
# OK (for loop is async)
idx = 0
async for x in async_gen():
g(x, idx)
idx += 1

5
crates/ruff_linter/src/rules/flake8_simplify/rules/enumerate_for_loop.rs
View file

@ -49,6 +49,11 @@ impl Violation for EnumerateForLoop {
/// SIM113 /// SIM113
pub(crate) fn enumerate_for_loop(checker: &mut Checker, for_stmt: &ast::StmtFor) { pub(crate) fn enumerate_for_loop(checker: &mut Checker, for_stmt: &ast::StmtFor) {
// If the loop is async, abort.
if for_stmt.is_async {
return;
}
// If the loop contains a `continue`, abort. // If the loop contains a `continue`, abort.
let mut visitor = LoopControlFlowVisitor::default(); let mut visitor = LoopControlFlowVisitor::default();
visitor.visit_body(&for_stmt.body); visitor.visit_body(&for_stmt.body);