language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-27 12:29:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix message for too-many-arguments lint (#8092)

Browse source 
## Summary

The lint checks for number of arguments in a function *definition*, but
the message says “function *call*”

## Test Plan

See what breaks and change the tests
This commit is contained in:
Philipp A 2023-10-20 18:17:19 +02:00 • committed by GitHub
parent f158536fbb
commit c8464c3a90
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff_linter/src/rules/pylint/rules/too_many_arguments.rs
View file

@ -53,7 +53,7 @@ impl Violation for TooManyArguments {
#[derive_message_formats] #[derive_message_formats]
fn message(&self) -> String { fn message(&self) -> String {
let TooManyArguments { c_args, max_args } = self; let TooManyArguments { c_args, max_args } = self;
format!("Too many arguments to function call ({c_args} > {max_args})") format!("Too many arguments in function definition ({c_args} > {max_args})")
} }
} }

10
crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR0913_too_many_arguments.py.snap
View file

@ -1,35 +1,35 @@
--- ---
source: crates/ruff_linter/src/rules/pylint/mod.rs source: crates/ruff_linter/src/rules/pylint/mod.rs
--- ---
too_many_arguments.py:1:5: PLR0913 Too many arguments to function call (8 > 5) too_many_arguments.py:1:5: PLR0913 Too many arguments in function definition (8 > 5)
| |
1 | def f(x, y, z, t, u, v, w, r): # Too many arguments (8/5) 1 | def f(x, y, z, t, u, v, w, r): # Too many arguments (8/5)
| ^ PLR0913 | ^ PLR0913
2 | pass 2 | pass
| |
too_many_arguments.py:17:5: PLR0913 Too many arguments to function call (6 > 5) too_many_arguments.py:17:5: PLR0913 Too many arguments in function definition (6 > 5)
| |
17 | def f(x, y, z, u=1, v=1, r=1): # Too many arguments (6/5) 17 | def f(x, y, z, u=1, v=1, r=1): # Too many arguments (6/5)
| ^ PLR0913 | ^ PLR0913
18 | pass 18 | pass
| |
too_many_arguments.py:25:5: PLR0913 Too many arguments to function call (6 > 5) too_many_arguments.py:25:5: PLR0913 Too many arguments in function definition (6 > 5)
| |
25 | def f(x, y, z, /, u, v, w): # Too many arguments (6/5) 25 | def f(x, y, z, /, u, v, w): # Too many arguments (6/5)
| ^ PLR0913 | ^ PLR0913
26 | pass 26 | pass
| |
too_many_arguments.py:29:5: PLR0913 Too many arguments to function call (6 > 5) too_many_arguments.py:29:5: PLR0913 Too many arguments in function definition (6 > 5)
| |
29 | def f(x, y, z, *, u, v, w): # Too many arguments (6/5) 29 | def f(x, y, z, *, u, v, w): # Too many arguments (6/5)
| ^ PLR0913 | ^ PLR0913
30 | pass 30 | pass
| |
too_many_arguments.py:33:5: PLR0913 Too many arguments to function call (9 > 5) too_many_arguments.py:33:5: PLR0913 Too many arguments in function definition (9 > 5)
| |
33 | def f(x, y, z, a, b, c, *, u, v, w): # Too many arguments (9/5) 33 | def f(x, y, z, a, b, c, *, u, v, w): # Too many arguments (9/5)
| ^ PLR0913 | ^ PLR0913

4
crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__max_args.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/ruff_linter/src/rules/pylint/mod.rs source: crates/ruff_linter/src/rules/pylint/mod.rs
--- ---
too_many_arguments_params.py:3:5: PLR0913 Too many arguments to function call (6 > 4) too_many_arguments_params.py:3:5: PLR0913 Too many arguments in function definition (6 > 4)
| |
1 | # Too many args (6/4) for max_args=4 1 | # Too many args (6/4) for max_args=4
2 | # OK for dummy_variable_rgx ~ "skip_.*" 2 | # OK for dummy_variable_rgx ~ "skip_.*"
@ -10,7 +10,7 @@ too_many_arguments_params.py:3:5: PLR0913 Too many arguments to function call (6
4 | pass 4 | pass
| |
too_many_arguments_params.py:9:5: PLR0913 Too many arguments to function call (6 > 4) too_many_arguments_params.py:9:5: PLR0913 Too many arguments in function definition (6 > 4)
| |
7 | # Too many args (6/4) for max_args=4 7 | # Too many args (6/4) for max_args=4
8 | # Too many args (6/5) for dummy_variable_rgx ~ "skip_.*" 8 | # Too many args (6/5) for dummy_variable_rgx ~ "skip_.*"

2
crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__max_args_with_dummy_variables.snap
View file

@ -1,7 +1,7 @@
--- ---
source: crates/ruff_linter/src/rules/pylint/mod.rs source: crates/ruff_linter/src/rules/pylint/mod.rs
--- ---
too_many_arguments_params.py:9:5: PLR0913 Too many arguments to function call (6 > 5) too_many_arguments_params.py:9:5: PLR0913 Too many arguments in function definition (6 > 5)
| |
7 | # Too many args (6/4) for max_args=4 7 | # Too many args (6/4) for max_args=4
8 | # Too many args (6/5) for dummy_variable_rgx ~ "skip_.*" 8 | # Too many args (6/5) for dummy_variable_rgx ~ "skip_.*"