language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 02:39:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] AST garbage collection (#18482)

Browse source 
## Summary

Garbage collect ASTs once we are done checking a given file. Queries
with a cross-file dependency on the AST will reparse the file on demand.
This reduces ty's peak memory usage by ~20-30%.

The primary change of this PR is adding a `node_index` field to every
AST node, that is assigned by the parser. `ParsedModule` can use this to
create a flat index of AST nodes any time the file is parsed (or
reparsed). This allows `AstNodeRef` to simply index into the current
instance of the `ParsedModule`, instead of storing a pointer directly.

The indices are somewhat hackily (using an atomic integer) assigned by
the `parsed_module` query instead of by the parser directly. Assigning
the indices in source-order in the (recursive) parser turns out to be
difficult, and collecting the nodes during semantic indexing is
impossible as `SemanticIndex` does not hold onto a specific
`ParsedModuleRef`, which the pointers in the flat AST are tied to. This
means that we have to do an extra AST traversal to assign and collect
the nodes into a flat index, but the small performance impact (~3% on
cold runs) seems worth it for the memory savings.

Part of https://github.com/astral-sh/ty/issues/214.
This commit is contained in:
Ibraheem Ahmed 2025-06-13 08:40:11 -04:00 • committed by GitHub
parent 76d9009a6e
commit c9dff5c7d5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
824 changed files with 25243 additions and 804 deletions
Download patch file Download diff file Expand all files Collapse all files

20
crates/ruff_python_parser/tests/snapshots/valid_syntax@expressions__name.py.snap
View file

@ -1,20 +1,22 @@
---
source: crates/ruff_python_parser/tests/fixtures.rs
input_file: crates/ruff_python_parser/resources/valid/expressions/name.py
snapshot_kind: text
---
## AST
```
Module(
ModModule {
node_index: AtomicNodeIndex(..),
range: 0..76,
body: [
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 0..1,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 0..1,
id: Name("_"),
ctx: Load,
@ -24,9 +26,11 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 2..5,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 3..4,
id: Name("_"),
ctx: Load,
@ -36,9 +40,11 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 6..8,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 6..8,
id: Name("__"),
ctx: Load,
@ -48,9 +54,11 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 9..17,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 9..17,
id: Name("__init__"),
ctx: Load,
@ -60,9 +68,11 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 18..22,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 18..22,
id: Name("name"),
ctx: Load,
@ -72,9 +82,11 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 23..29,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 24..28,
id: Name("name"),
ctx: Load,
@ -84,9 +96,11 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 60..65,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 60..65,
id: Name("match"),
ctx: Load,
@ -96,9 +110,11 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 66..70,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 66..70,
id: Name("case"),
ctx: Load,
@ -108,9 +124,11 @@ Module(
),
Expr(
StmtExpr {
node_index: AtomicNodeIndex(..),
range: 71..75,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
range: 71..75,
id: Name("type"),
ctx: Load,