language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-26 11:59:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor: Introduce CacheKey trait (#3323)

Browse source 
This PR introduces a new `CacheKey` trait for types that can be used as a cache key.

I'm not entirely sure if this is worth the "overhead", but I was surprised to find `HashableHashSet` and got scared when I looked at the time complexity of the `hash` function. These implementations must be extremely slow in hashed collections.

I then searched for usages and quickly realized that only the cache uses these `Hash` implementations, where performance is less sensitive.

This PR introduces a new `CacheKey` trait to communicate the difference between a hash and computing a key for the cache. The new trait can be implemented for types that don't implement `Hash` for performance reasons, and we can define additional constraints on the implementation:  For example, we'll want to enforce portability when we add remote caching support. Using a different trait further allows us not to implement it for types without stable identities (e.g. pointers) or use other implementations than the standard hash function.
This commit is contained in:
Micha Reiser 2023-03-03 19:29:49 +01:00 • committed by GitHub
parent d1288dc2b1
commit cdbe2ee496
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
53 changed files with 842 additions and 331 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff_cli/src/commands/clean.rs
View file

@ -6,9 +6,9 @@ use colored::Colorize;
use path_absolutize::path_dedot;
use walkdir::WalkDir;
use ruff::cache::CACHE_DIR_NAME;
use ruff::fs;
use ruff::logging::LogLevel;
use ruff_cache::CACHE_DIR_NAME;
/// Clear any caches in the current directory or any subdirectories.
pub fn clean(level: LogLevel) -> Result<()> {