language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-19 10:01:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Clarify PEP 8 relationship to whitespace-around-operator rules (#18870)

Browse source 
## Summary

See: https://github.com/astral-sh/ruff/issues/18868.
This commit is contained in:
Charlie Marsh 2025-06-22 20:30:34 -04:00 • committed by GitHub
parent 9089493263
commit cfec89e8c3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 28 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

37
crates/ruff_linter/src/rules/pycodestyle/rules/logical_lines/missing_whitespace_around_operator.rs
View file

@ -12,7 +12,8 @@ use crate::{AlwaysFixableViolation, Edit, Fix};
/// ///
/// ## Why is this bad? /// ## Why is this bad?
/// According to [PEP 8], there should be one space before and after all /// According to [PEP 8], there should be one space before and after all
/// operators. /// assignment (`=`), augmented assignment (`+=`, `-=`, etc.), comparison,
/// and Booleans operators.
/// ///
/// ## Example /// ## Example
/// ```python /// ```python
@ -46,8 +47,14 @@ impl AlwaysFixableViolation for MissingWhitespaceAroundOperator {
/// Checks for missing whitespace arithmetic operators. /// Checks for missing whitespace arithmetic operators.
/// ///
/// ## Why is this bad? /// ## Why is this bad?
/// According to [PEP 8], there should be one space before and after an /// [PEP 8] recommends never using more than one space, and always having the
/// arithmetic operator (+, -, /, and *). /// same amount of whitespace on both sides of a binary operator.
///
/// For consistency, this rule enforces one space before and after an
/// arithmetic operator (`+`, `-`, `/`, and `*`).
///
/// (Note that [PEP 8] suggests only adding whitespace around the operator with
/// the lowest precedence, but that authors should "use [their] own judgment".)
/// ///
/// ## Example /// ## Example
/// ```python /// ```python
@ -59,7 +66,7 @@ impl AlwaysFixableViolation for MissingWhitespaceAroundOperator {
/// number = 40 + 2 /// number = 40 + 2
/// ``` /// ```
/// ///
/// [PEP 8]: https://peps.python.org/pep-0008/#pet-peeves /// [PEP 8]: https://peps.python.org/pep-0008/#other-recommendations
// E226 // E226
#[derive(ViolationMetadata)] #[derive(ViolationMetadata)]
pub(crate) struct MissingWhitespaceAroundArithmeticOperator; pub(crate) struct MissingWhitespaceAroundArithmeticOperator;
@ -79,8 +86,14 @@ impl AlwaysFixableViolation for MissingWhitespaceAroundArithmeticOperator {
/// Checks for missing whitespace around bitwise and shift operators. /// Checks for missing whitespace around bitwise and shift operators.
/// ///
/// ## Why is this bad? /// ## Why is this bad?
/// According to [PEP 8], there should be one space before and after bitwise and /// [PEP 8] recommends never using more than one space, and always having the
/// shift operators (<<, >>, &, |, ^). /// same amount of whitespace on both sides of a binary operator.
///
/// For consistency, this rule enforces one space before and after bitwise and
/// shift operators (`<<`, `>>`, `&`, `|`, `^`).
///
/// (Note that [PEP 8] suggests only adding whitespace around the operator with
/// the lowest precedence, but that authors should "use [their] own judgment".)
/// ///
/// ## Example /// ## Example
/// ```python /// ```python
@ -92,7 +105,7 @@ impl AlwaysFixableViolation for MissingWhitespaceAroundArithmeticOperator {
/// x = 128 << 1 /// x = 128 << 1
/// ``` /// ```
/// ///
/// [PEP 8]: https://peps.python.org/pep-0008/#pet-peeves /// [PEP 8]: https://peps.python.org/pep-0008/#other-recommendations
// E227 // E227
#[derive(ViolationMetadata)] #[derive(ViolationMetadata)]
pub(crate) struct MissingWhitespaceAroundBitwiseOrShiftOperator; pub(crate) struct MissingWhitespaceAroundBitwiseOrShiftOperator;
@ -112,8 +125,14 @@ impl AlwaysFixableViolation for MissingWhitespaceAroundBitwiseOrShiftOperator {
/// Checks for missing whitespace around the modulo operator. /// Checks for missing whitespace around the modulo operator.
/// ///
/// ## Why is this bad? /// ## Why is this bad?
/// According to [PEP 8], the modulo operator (%) should have whitespace on /// [PEP 8] recommends never using more than one space, and always having the
/// either side of it. /// same amount of whitespace on both sides of a binary operator.
///
/// For consistency, this rule enforces one space before and after a modulo
/// operator (`%`).
///
/// (Note that [PEP 8] suggests only adding whitespace around the operator with
/// the lowest precedence, but that authors should "use [their] own judgment".)
/// ///
/// ## Example /// ## Example
/// ```python /// ```python