language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-29 13:25:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] Add failing tests for iterating over maybe-iterable unions (#14016)

Browse source
This commit is contained in:
Alex Waygood 2024-10-31 18:20:21 +00:00 • committed by GitHub
parent 9a6b08b557
commit d1189c20df
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 61 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/red_knot_python_semantic/src/types.rs
View file

@ -1090,7 +1090,7 @@ impl<'db> Type<'db> {
};
}
if let Type::Unknown | Type::Any = self {
if matches!(self, Type::Unknown | Type::Any | Type::Todo) {
// Explicit handling of `Unknown` and `Any` necessary until `type[Unknown]` and
// `type[Any]` are not defined as `Todo` anymore.
return IterationOutcome::Iterable { element_ty: self };
@ -1185,9 +1185,9 @@ impl<'db> Type<'db> {
// TODO can we do better here? `type[LiteralString]`?
Type::StringLiteral(_) | Type::LiteralString => KnownClass::Str.to_class(db),
// TODO: `type[Any]`?
Type::Any => Type::Todo,
Type::Any => Type::Any,
// TODO: `type[Unknown]`?
Type::Unknown => Type::Todo,
Type::Unknown => Type::Unknown,
// TODO intersections
Type::Intersection(_) => Type::Todo,
Type::Todo => Type::Todo,