language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-28 04:45:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[pyupgrade] Ignore is_typeddict and TypedDict for deprecated-import (UP035) (#15800)

Browse source
This commit is contained in:
InSync 2025-01-30 01:05:46 +07:00 • committed by GitHub
parent 6c1e19592e
commit d151ca85d3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/ruff_linter/resources/test/fixtures/pyupgrade/UP035.py vendored
View file

@ -109,3 +109,9 @@ from typing_extensions import CapsuleType
# UP035 on py313+ only # UP035 on py313+ only
from typing_extensions import deprecated from typing_extensions import deprecated
# https://github.com/astral-sh/ruff/issues/15780
from typing_extensions import is_typeddict
# https://github.com/astral-sh/ruff/pull/15800#pullrequestreview-2580704217
from typing_extensions import TypedDict

7
crates/ruff_linter/src/rules/pyupgrade/rules/deprecated_import.rs
View file

@ -308,7 +308,9 @@ const TYPING_EXTENSIONS_TO_TYPING_310: &[&str] = &[
"TypeGuard", "TypeGuard",
"get_args", "get_args",
"get_origin", "get_origin",
"is_typeddict", // Introduced in Python 3.10, but `typing_extensions` equivalent
// also checks for `typing_extensions.TypedDict` in addition to `typing.TypedDict`.
// "is_typeddict",
]; ];
// Python 3.11+ // Python 3.11+
@ -382,13 +384,14 @@ const TYPING_EXTENSIONS_TO_TYPING_313: &[&str] = &[
// Introduced in Python 3.8, but typing_extensions // Introduced in Python 3.8, but typing_extensions
// backports features and bugfixes from py313: // backports features and bugfixes from py313:
"Protocol", "Protocol",
"TypedDict",
"runtime_checkable", "runtime_checkable",
// Introduced in earlier Python versions, // Introduced in earlier Python versions,
// but typing_extensions backports PEP-696: // but typing_extensions backports PEP-696:
"ParamSpec", "ParamSpec",
"TypeVar", "TypeVar",
"TypeVarTuple", "TypeVarTuple",
// `typing_extensions` backports PEP 728 (TypedDict with Typed Extra Items)
// "TypedDict",
]; ];
// Members of `typing_extensions` that were moved to `types`. // Members of `typing_extensions` that were moved to `types`.

3
crates/ruff_linter/src/rules/pyupgrade/snapshots/ruff_linter__rules__pyupgrade__tests__UP035.py.snap
View file

@ -1188,3 +1188,6 @@ UP035.py:111:1: UP035 [*] Import from `warnings` instead: `deprecated`
110 110 | # UP035 on py313+ only 110 110 | # UP035 on py313+ only
111 |-from typing_extensions import deprecated 111 |-from typing_extensions import deprecated
111 |+from warnings import deprecated 111 |+from warnings import deprecated
112 112 |
113 113 |
114 114 | # https://github.com/astral-sh/ruff/issues/15780