language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 13:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Add unary inference for integer and boolean literals (#13559)

Browse source 
## Summary

Just trying to familiarize myself with the general patterns, testing,
etc.

Part of https://github.com/astral-sh/ruff/issues/12701.
This commit is contained in:
Charlie Marsh 2024-09-30 12:29:06 -04:00 • committed by GitHub
parent 5f4b282327
commit d86b73eb3d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 65 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

65
crates/red_knot_python_semantic/src/types/infer.rs
View file

@ -2209,8 +2209,16 @@ impl<'db> TypeInferenceBuilder<'db> {
} = unary; } = unary;
match (op, self.infer_expression(operand)) { match (op, self.infer_expression(operand)) {
(UnaryOp::UAdd, Type::IntLiteral(value)) => Type::IntLiteral(value),
(UnaryOp::USub, Type::IntLiteral(value)) => Type::IntLiteral(-value), (UnaryOp::USub, Type::IntLiteral(value)) => Type::IntLiteral(-value),
(UnaryOp::Invert, Type::IntLiteral(value)) => Type::IntLiteral(!value),
(UnaryOp::UAdd, Type::BooleanLiteral(bool)) => Type::IntLiteral(i64::from(bool)),
(UnaryOp::USub, Type::BooleanLiteral(bool)) => Type::IntLiteral(-i64::from(bool)),
(UnaryOp::Invert, Type::BooleanLiteral(bool)) => Type::IntLiteral(!i64::from(bool)),
(UnaryOp::Not, ty) => ty.bool(self.db).negate().into_type(self.db), (UnaryOp::Not, ty) => ty.bool(self.db).negate().into_type(self.db),
_ => Type::Unknown, // TODO other unary op types _ => Type::Unknown, // TODO other unary op types
} }
} }
@ -6571,4 +6579,61 @@ mod tests {
assert_public_ty(&db, "/src/a.py", "c", "bool"); assert_public_ty(&db, "/src/a.py", "c", "bool");
Ok(()) Ok(())
} }
#[test]
fn unary_add() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"/src/a.py",
"
a = +0
b = +1
c = +True
",
)?;
assert_public_ty(&db, "/src/a.py", "a", "Literal[0]");
assert_public_ty(&db, "/src/a.py", "b", "Literal[1]");
assert_public_ty(&db, "/src/a.py", "c", "Literal[1]");
Ok(())
}
#[test]
fn unary_sub() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"/src/a.py",
"
a = -0
b = -1
c = -True
",
)?;
assert_public_ty(&db, "/src/a.py", "a", "Literal[0]");
assert_public_ty(&db, "/src/a.py", "b", "Literal[-1]");
assert_public_ty(&db, "/src/a.py", "c", "Literal[-1]");
Ok(())
}
#[test]
fn unary_invert() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"/src/a.py",
"
a = ~0
b = ~1
c = ~True
",
)?;
assert_public_ty(&db, "/src/a.py", "a", "Literal[-1]");
assert_public_ty(&db, "/src/a.py", "b", "Literal[-2]");
assert_public_ty(&db, "/src/a.py", "c", "Literal[-2]");
Ok(())
}
} }