language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-19 10:01:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid flagging missing whitespace for decorators (#4454)

Browse source
This commit is contained in:
Charlie Marsh 2023-05-16 13:15:01 -04:00 • committed by GitHub
parent 7e0d018b35
commit d9c3f8e249
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/ruff/resources/test/fixtures/pycodestyle/E22.py vendored
View file

@ -160,6 +160,7 @@ if alpha[:-i]:
*a, b = (1, 2, 3) *a, b = (1, 2, 3)
@decorator
def squares(n): def squares(n):
return (i**2 for i in range(n)) return (i**2 for i in range(n))

8
crates/ruff/src/rules/pycodestyle/rules/logical_lines/missing_whitespace_around_operator.rs
View file

@ -86,13 +86,19 @@ pub(crate) fn missing_whitespace_around_operator(
); );
NeedsSpace::from(!slash_in_func) NeedsSpace::from(!slash_in_func)
} else if kind.is_unary() || kind == TokenKind::DoubleStar { } else if kind.is_unary()
|| matches!(
kind,
TokenKind::Star | TokenKind::DoubleStar | TokenKind::At
)
{
let is_binary = prev_token.map_or(false, |prev_token| { let is_binary = prev_token.map_or(false, |prev_token| {
let prev_kind = prev_token.kind(); let prev_kind = prev_token.kind();
// Check if the operator is used as a binary operator. // Check if the operator is used as a binary operator.
// Allow unary operators: -123, -x, +1. // Allow unary operators: -123, -x, +1.
// Allow argument unpacking: foo(*args, **kwargs) // Allow argument unpacking: foo(*args, **kwargs)
// Allow decorators: @foo, @foo(1)
matches!( matches!(
prev_kind, prev_kind,
TokenKind::Rpar | TokenKind::Rsqb | TokenKind::Rbrace TokenKind::Rpar | TokenKind::Rsqb | TokenKind::Rbrace

2
crates/ruff_python_ast/src/token_kind.rs
View file

@ -174,7 +174,7 @@ impl TokenKind {
#[inline] #[inline]
pub const fn is_unary(&self) -> bool { pub const fn is_unary(&self) -> bool {
matches!(self, TokenKind::Plus | TokenKind::Minus | TokenKind::Star) matches!(self, TokenKind::Plus | TokenKind::Minus)
} }
#[inline] #[inline]