language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 02:39:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Add some exceptions for FBT003 (#3247) (#4867)

Browse source
This commit is contained in:
Allison Karlitskaya 2023-06-05 18:44:49 +02:00 • committed by GitHub
parent 209aaa5add
commit dc223fd3ca
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py vendored
View file

@ -57,12 +57,16 @@ dict.fromkeys(("world",), True)
{}.deploy(True, False)
getattr(someobj, attrname, False)
mylist.index(True)
bool(False)
int(True)
str(int(False))
cfg.get("hello", True)
cfg.getint("hello", True)
cfg.getfloat("hello", True)
cfg.getboolean("hello", True)
os.set_blocking(0, False)
g_action.set_enabled(True)
settings.set_enable_developer_extras(True)
class Registry:

3
crates/ruff/src/rules/flake8_boolean_trap/helpers.rs
View file

@ -10,6 +10,7 @@ pub(super) const FUNC_CALL_NAME_ALLOWLIST: &[&str] = &[
"assertEquals",
"assertNotEqual",
"assertNotEquals",
"bool",
"bytes",
"count",
"failIfEqual",
@ -27,6 +28,8 @@ pub(super) const FUNC_CALL_NAME_ALLOWLIST: &[&str] = &[
"param",
"pop",
"remove",
"set_blocking",
"set_enabled",
"setattr",
"__setattr__",
"setdefault",

8
crates/ruff/src/rules/flake8_boolean_trap/snapshots/ruff__rules__flake8_boolean_trap__tests__FBT001_FBT.py.snap
View file

@ -81,12 +81,12 @@ FBT.py:19:5: FBT001 Boolean positional arg in function definition
23 | kwonly_nonvalued_nohint,
|
FBT.py:81:19: FBT001 Boolean positional arg in function definition
FBT.py:85:19: FBT001 Boolean positional arg in function definition
|
81 | # FBT001: Boolean positional arg in function definition
82 | def foo(self, value: bool) -> None:
85 | # FBT001: Boolean positional arg in function definition
86 | def foo(self, value: bool) -> None:
| ^^^^^^^^^^^ FBT001
83 | pass
87 | pass
|

8
crates/ruff/src/rules/flake8_boolean_trap/snapshots/ruff__rules__flake8_boolean_trap__tests__FBT003_FBT.py.snap
View file

@ -28,4 +28,12 @@ FBT.py:57:17: FBT003 Boolean positional value in function call
61 | mylist.index(True)
|
FBT.py:69:38: FBT003 Boolean positional value in function call
|
69 | os.set_blocking(0, False)
70 | g_action.set_enabled(True)
71 | settings.set_enable_developer_extras(True)
| ^^^^ FBT003
|