language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-03 07:04:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Implement F541 (#12)

Browse source
This commit is contained in:
Charlie Marsh 2022-08-16 10:47:13 -04:00 • committed by GitHub
parent 3b1b53dacf
commit ddd554f9de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 69 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/check_ast.rs
View file

@ -1,9 +1,10 @@
use std::collections::HashSet;
use rustpython_parser::ast::{Arg, Arguments, ExprKind, Stmt, StmtKind, Suite};
use rustpython_parser::ast::{Arg, Arguments, Expr, ExprKind, Stmt, StmtKind, Suite};
use crate::checks::{Check, CheckKind};
use crate::visitor::{walk_arguments, walk_stmt, Visitor};
use crate::visitor;
use crate::visitor::Visitor;
#[derive(Default)]
struct Checker {
@ -34,7 +35,23 @@ impl Visitor for Checker {
_ => {}
}
walk_stmt(self, stmt);
visitor::walk_stmt(self, stmt);
}
fn visit_expr(&mut self, expr: &Expr) {
if let ExprKind::JoinedStr { values } = &expr.node {
if !values
.iter()
.any(|value| matches!(value.node, ExprKind::FormattedValue { .. }))
{
self.checks.push(Check {
kind: CheckKind::FStringMissingPlaceholders,
location: expr.location,
});
}
}
visitor::walk_expr(self, expr);
}
fn visit_arguments(&mut self, arguments: &Arguments) {
@ -66,7 +83,7 @@ impl Visitor for Checker {
idents.insert(ident.clone());
}
walk_arguments(self, arguments);
visitor::walk_arguments(self, arguments);
}
}