language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-10-02 06:42:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

When only unsafe fixes are available, include note that no fixes are available first (#7950)

Browse source 
I believe this is a bit clearer.

When no fixes are available (safe _and_ unsafe) we will not include a
message at all.
This commit is contained in:
Zanie Blue 2023-10-13 12:43:13 -05:00 • committed by GitHub
parent 8255e4ed6c
commit ddffadb4b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ruff_cli/src/printer.rs
View file

@ -161,7 +161,7 @@ impl Printer {
"es" "es"
}; };
writeln!(writer, writeln!(writer,
"{} hidden fix{es} can be enabled with the `--unsafe-fixes` option.", "No fixes available ({} hidden fix{es} can be enabled with the `--unsafe-fixes` option).",
fixables.unapplicable_unsafe fixables.unapplicable_unsafe
)?; )?;
} }

10
crates/ruff_cli/tests/integration_test.rs
View file

@ -945,7 +945,7 @@ fn check_hints_hidden_unsafe_fixes_with_no_safe_fixes() {
----- stdout ----- ----- stdout -----
-:1:14: F601 Dictionary key literal `'a'` repeated -:1:14: F601 Dictionary key literal `'a'` repeated
Found 1 error. Found 1 error.
1 hidden fix can be enabled with the `--unsafe-fixes` option. No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).
----- stderr ----- ----- stderr -----
"###); "###);
@ -1002,7 +1002,7 @@ fn fix_applies_safe_fixes_by_default() {
----- stderr ----- ----- stderr -----
-:1:14: F601 Dictionary key literal `'a'` repeated -:1:14: F601 Dictionary key literal `'a'` repeated
Found 2 errors (1 fixed, 1 remaining). Found 2 errors (1 fixed, 1 remaining).
1 hidden fix can be enabled with the `--unsafe-fixes` option. No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).
"###); "###);
} }
@ -1112,7 +1112,7 @@ fn fix_only_unsafe_fixes_available() {
----- stderr ----- ----- stderr -----
-:1:14: F601 Dictionary key literal `'a'` repeated -:1:14: F601 Dictionary key literal `'a'` repeated
Found 1 error. Found 1 error.
1 hidden fix can be enabled with the `--unsafe-fixes` option. No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).
"###); "###);
} }
@ -1317,7 +1317,7 @@ extend-unsafe-fixes = ["UP034"]
-:1:14: F601 Dictionary key literal `'a'` repeated -:1:14: F601 Dictionary key literal `'a'` repeated
-:2:7: UP034 Avoid extraneous parentheses -:2:7: UP034 Avoid extraneous parentheses
Found 2 errors. Found 2 errors.
2 hidden fixes can be enabled with the `--unsafe-fixes` option. No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).
----- stderr ----- ----- stderr -----
"###); "###);
@ -1397,7 +1397,7 @@ extend-safe-fixes = ["UP034"]
-:1:14: F601 Dictionary key literal `'a'` repeated -:1:14: F601 Dictionary key literal `'a'` repeated
-:2:7: UP034 Avoid extraneous parentheses -:2:7: UP034 Avoid extraneous parentheses
Found 2 errors. Found 2 errors.
2 hidden fixes can be enabled with the `--unsafe-fixes` option. No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).
----- stderr ----- ----- stderr -----
"###); "###);