From ed2e90371b2affd985e423c4cd821dba1a450077 Mon Sep 17 00:00:00 2001 From: GiGaGon <107241144+MeGaGiGaGon@users.noreply.github.com> Date: Sat, 28 Jun 2025 08:11:38 -0700 Subject: [PATCH] [`flake8-async`] Make `ASYNC210` example error out-of-the-box (#18977) ## Summary Part of #18972 This PR makes [blocking-http-call-in-async-function (ASYNC210)](https://docs.astral.sh/ruff/rules/blocking-http-call-in-async-function/#blocking-http-call-in-async-function-async210)'s example error out-of-the-box [Old example](https://play.ruff.rs/20cba4f4-fe2f-428a-a721-311d1a081e64) ```py async def fetch(): urllib.request.urlopen("https://example.com/foo/bar").read() ``` [New example](https://play.ruff.rs/5ca2a10d-5294-49ee-baee-0447f7188d9b) ```py import urllib async def fetch(): urllib.request.urlopen("https://example.com/foo/bar").read() ``` ## Test Plan N/A, no functionality/tests affected --- .../src/rules/flake8_async/rules/blocking_http_call.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/ruff_linter/src/rules/flake8_async/rules/blocking_http_call.rs b/crates/ruff_linter/src/rules/flake8_async/rules/blocking_http_call.rs index ceb69137e3..b6e9d045ad 100644 --- a/crates/ruff_linter/src/rules/flake8_async/rules/blocking_http_call.rs +++ b/crates/ruff_linter/src/rules/flake8_async/rules/blocking_http_call.rs @@ -20,12 +20,18 @@ use crate::checkers::ast::Checker; /// /// ## Example /// ```python +/// import urllib +/// +/// /// async def fetch(): /// urllib.request.urlopen("https://example.com/foo/bar").read() /// ``` /// /// Use instead: /// ```python +/// import aiohttp +/// +/// /// async def fetch(): /// async with aiohttp.ClientSession() as session: /// async with session.get("https://example.com/foo/bar") as resp: