language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 13:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[red-knot] implement attribute of union (#12601)

Browse source 
I hit this `todo!` trying to run type inference over some real modules.
Since it's a one-liner to implement it, I just did that rather than
changing to `Type::Unknown`.
This commit is contained in:
Carl Meyer 2024-07-31 19:45:24 -07:00 • committed by GitHub
parent d774a3bd48
commit ee0518e8f7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 31 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/red_knot_python_semantic/src/types.rs
View file

@ -157,12 +157,15 @@ impl<'db> Type<'db> {
// TODO MRO? get_own_instance_member, get_instance_member
todo!("attribute lookup on Instance type")
}
Type::Union(_) => {
// TODO perform the get_member on each type in the union
// TODO return the union of those results
// TODO if any of those results is `None` then include Unknown in the result union
todo!("attribute lookup on Union type")
}
Type::Union(union) => Type::Union(
union
.elements(db)
.iter()
.fold(UnionTypeBuilder::new(db), |builder, element_ty| {
builder.add(element_ty.member(db, name))
})
.build(),
),
Type::Intersection(_) => {
// TODO perform the get_member on each type in the intersection
// TODO return the intersection of those results

22
crates/red_knot_python_semantic/src/types/infer.rs
View file

@ -2238,6 +2238,28 @@ mod tests {
Ok(())
}
#[test]
fn attribute_of_union() -> anyhow::Result<()> {
let mut db = setup_db();
db.write_dedented(
"/src/a.py",
"
if flag:
class C:
x = 1
else:
class C:
x = 2
y = C.x
",
)?;
assert_public_ty(&db, "/src/a.py", "y", "Literal[1, 2]");
Ok(())
}
fn first_public_def<'db>(db: &'db TestDb, file: File, name: &str) -> Definition<'db> {
let scope = global_scope(db, file);
*use_def_map(db, scope)